From: Saurav Girepunje <saurav.girepunje@gmail.com>
To: Pavel Skripkin <paskripkin@gmail.com>,
Greg KH <gregkh@linuxfoundation.org>
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
straube.linux@gmail.com, martin@kaiser.cx,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
saurav.girepunje@hotmail.com
Subject: Re: [PATCH v2] staging: r8188eu: os_dep: remove the goto statement
Date: Fri, 5 Nov 2021 22:48:34 +0530 [thread overview]
Message-ID: <9bc5a088-2cdc-1bbd-6459-d1b95e25aa9c@gmail.com> (raw)
In-Reply-To: <ecf6ba8e-8273-0d77-5ceb-3ad44179d3a3@gmail.com>
On 05/11/21 4:06 pm, Pavel Skripkin wrote:
> On 11/5/21 12:53, Greg KH wrote:
>> Right after this, ret8 is set, but never checked, which looks like a bug
>> to me. Can you work on fixing that after I take this patch?
Yes, I will send a patch removing a local variable for return value and changing
the return type of function rtw_init_default_value . As rtw_init_default_value always return
success and the return value of this function is not checked.
>>
>> thanks,
>>
>> greg k-h
>>
>
> ret8 is returned from this function, but as I said [1] it can be just removed. It will be always set to _SUCCESS.
>
>
>
> [1] https://lore.kernel.org/linux-staging/f26b4aec-c0a1-8c93-b34e-8b1a36ac81b3@gmail.com/
>
>
Pavel also mentioned to remove the local variable ret8.
> With regards,
> Pavel Skripkin
Thanks,
Saurav
prev parent reply other threads:[~2021-11-05 17:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 15:48 [PATCH v2] staging: r8188eu: os_dep: remove the goto statement Saurav Girepunje
2021-11-05 9:53 ` Greg KH
2021-11-05 10:36 ` Pavel Skripkin
2021-11-05 17:18 ` Saurav Girepunje [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bc5a088-2cdc-1bbd-6459-d1b95e25aa9c@gmail.com \
--to=saurav.girepunje@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=paskripkin@gmail.com \
--cc=phil@philpotter.co.uk \
--cc=saurav.girepunje@hotmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox