From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Dorine Tipo <dorine.a.tipo@gmail.com>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: rtl8712: Align parenthesis in usb_ops_linux.c
Date: Wed, 28 Aug 2024 20:48:42 +0200 [thread overview]
Message-ID: <9c1ab010-1436-4c54-9fa5-418472a9427f@gmail.com> (raw)
In-Reply-To: <20240828082935.GA3815@ubuntu-focal>
On 8/28/24 10:29, Dorine Tipo wrote:
> Fix the parenthesis alignment in r8712_read_port() function to match
> the opening parenthesis.
> This improves code readability and adheres to the kernel coding style.
>
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> ---
> Changelog:
> V2: Edited the subject line to fix a typo and make it more unique as
> suggested by Philipp.
> Edited the description to include the reason for the change.
>
> drivers/staging/rtl8712/usb_ops_linux.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8712/usb_ops_linux.c b/drivers/staging/rtl8712/usb_ops_linux.c
> index 0a3451cdc8a1..4a34824830e3 100644
> --- a/drivers/staging/rtl8712/usb_ops_linux.c
> +++ b/drivers/staging/rtl8712/usb_ops_linux.c
> @@ -221,7 +221,7 @@ static void r8712_usb_read_port_complete(struct urb *purb)
> fallthrough;
> case -EPROTO:
> r8712_read_port(padapter, precvpriv->ff_hwaddr, 0,
> - (unsigned char *)precvbuf);
> + (unsigned char *)precvbuf);
> break;
> case -EINPROGRESS:
> netdev_err(padapter->pnetdev, "ERROR: URB IS IN PROGRESS!\n");
> --
> 2.25.1
>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> AW-NU120
prev parent reply other threads:[~2024-08-28 18:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 8:29 [PATCH v2] staging: rtl8712: Align parenthesis in usb_ops_linux.c Dorine Tipo
2024-08-28 18:48 ` Philipp Hortmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c1ab010-1436-4c54-9fa5-418472a9427f@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=dorine.a.tipo@gmail.com \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox