From: "Adrian Barnaś" <abarnas@google.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Hans de Goede <hansg@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Andy Shevchenko <andy@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH v2 1/3] staging: media: atomisp: Remove unnecessary inline declaration in gdc.c
Date: Thu, 21 Aug 2025 15:37:11 +0200 [thread overview]
Message-ID: <CAATBrPH-TTAdpCyCopZNsgTCqwnTBxjEiBg9HQ8KnJaPESA6Sg@mail.gmail.com> (raw)
In-Reply-To: <aKcRDWlRQ1gughvQ@stanley.mountain>
Thank you Dan
Posted v3 applying your suggestions.
Best regards
Adrian Barnaś
On Thu, Aug 21, 2025 at 2:29 PM Dan Carpenter <dan.carpenter@linaro.org> wrote:
>
> On Thu, Aug 21, 2025 at 07:01:28AM +0000, Adrian Barnaś wrote:
> > Get rid of gdc_reg_store() forward declaration because it brings no value
>
> The subject should say "forward" instead of "inline". Also add a period
> to the end of your sentences.
>
> regards,
> dan carpenter
>
prev parent reply other threads:[~2025-08-21 13:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-21 7:01 [PATCH v2 1/3] staging: media: atomisp: Remove unnecessary inline declaration in gdc.c Adrian Barnaś
2025-08-21 7:01 ` [PATCH v2 2/3] staging: media: atomisp: Whitespaces style cleanup " Adrian Barnaś
2025-08-21 7:01 ` [PATCH v2 3/3] staging: media: atomisp: Remove return from end of void function " Adrian Barnaś
2025-08-21 12:29 ` [PATCH v2 1/3] staging: media: atomisp: Remove unnecessary inline declaration " Dan Carpenter
2025-08-21 13:37 ` Adrian Barnaś [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAATBrPH-TTAdpCyCopZNsgTCqwnTBxjEiBg9HQ8KnJaPESA6Sg@mail.gmail.com \
--to=abarnas@google.com \
--cc=andy@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).