Re: [PATCH 2/3] media: imx: Rename imx7-mipi-csis.c to imx-mipi-csis.c

Laurent Pinchart
2022-02-14T11:22:24Z

Hi Jacopo,

On Mon, Feb 14, 2022 at 12:20:00PM +0100, Jacopo Mondi wrote:
> On Mon, Feb 14, 2022 at 10:20:57AM +0000, Rui Miguel Silva wrote:
> > Hey Jacopo,
> > I think you by now saw the kernel test report.
> >
> > You miss the rename in the makefile also.
>
> Yes, that's pretty stupid sorry, I forgot to add the Makefile :(
>
> I'll fix in v2
>
> Laurent, do you want to squash 2/3 and 3/3 to have the symbols and the
> file rename in the same patch ?

I think I'd prefer that, but if it ends up being messy you can keep them
separate.

> > ------
> > Cheers,
> > Rui
> > On Fri Feb 11, 2022 at 6:02 PM WET, Jacopo Mondi wrote:
> >
> > > Rename the imx7-mipi-csis.c driver to remove the reference to i.MX7.
> > >
> > > The driver is for an IP core found on i.MX7 and i.MX8 SoC so do not
> > > specify a SoC version number in the driver name.
> > >
> > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> > > ---
> > > MAINTAINERS | 2 +-
> > > .../media/platform/imx/{imx7-mipi-csis.c => imx-mipi-csis.c} | 0
> > > 2 files changed, 1 insertion(+), 1 deletion(-)
> > > rename drivers/media/platform/imx/{imx7-mipi-csis.c => imx-mipi-csis.c} (100%)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 5bdb8c881b0b..7def3b7d56bc 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -11891,7 +11891,7 @@ T: git git://linuxtv.org/media_tree.git
> > > F: Documentation/admin-guide/media/imx7.rst
> > > F: Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml
> > > F: Documentation/devicetree/bindings/media/nxp,imx7-mipi-csi2.yaml
> > > -F: drivers/media/platform/imx/imx7-mipi-csis.c
> > > +F: drivers/media/platform/imx/imx-mipi-csis.c
> > > F: drivers/staging/media/imx/imx7-media-csi.c
> > >
> > > MEDIA DRIVERS FOR HELENE
> > > diff --git a/drivers/media/platform/imx/imx7-mipi-csis.c b/drivers/media/platform/imx/imx-mipi-csis.c
> > > similarity index 100%
> > > rename from drivers/media/platform/imx/imx7-mipi-csis.c
> > > rename to drivers/media/platform/imx/imx-mipi-csis.c

--
Regards,

Laurent Pinchart