[PATCH v2] staging: rtl8723bs: remove hardcoded dead debug code

[PATCH v2] staging: rtl8723bs: remove hardcoded dead debug code

[SAJJA EASWAR SAI]

The debug code is guarded by a constant false condition and is never
executed. Remove it to simplify the code. This also removes the now
unused variable 'pattrib'.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202601302336.Jt5bRreu-lkp@intel.com/
Signed-off-by: SAJJA EASWAR SAI <eshwarsajja20@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
index ac49bfbaa..ae16f045b 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
@@ -1849,7 +1849,6 @@ unsigned int OnAction_ht(struct adapter *padapter, union recv_frame *precv_frame
 unsigned int OnAction_sa_query(struct adapter *padapter, union recv_frame *precv_frame)
 {
 	u8 *pframe = precv_frame->u.hdr.rx_data;
-	struct rx_pkt_attrib *pattrib = &precv_frame->u.hdr.attrib;
 	struct mlme_ext_priv *pmlmeext = &(padapter->mlmeextpriv);
 	unsigned short tid;
 
@@ -1865,15 +1864,6 @@ unsigned int OnAction_sa_query(struct adapter *padapter, union recv_frame *precv
 	default:
 		break;
 	}
-	if (0) {
-		int pp;
-
-		netdev_dbg(padapter->pnetdev, "pattrib->pktlen = %d =>", pattrib->pkt_len);
-		for (pp = 0; pp < pattrib->pkt_len; pp++)
-			pr_cont(" %02x ", pframe[pp]);
-		pr_cont("\n");
-	}
-
 	return _SUCCESS;
 }
 
-- 
2.52.0

Re: [PATCH v2] staging: rtl8723bs: remove hardcoded dead debug code

[Ethan Tidmore]

On Fri Jan 30, 2026 at 11:26 AM CST, SAJJA EASWAR SAI wrote:
>  	default:
>  		break;
>  	}
> -	if (0) {
> -		int pp;
> -
> -		netdev_dbg(padapter->pnetdev, "pattrib->pktlen = %d =>", pattrib->pkt_len);
> -		for (pp = 0; pp < pattrib->pkt_len; pp++)
> -			pr_cont(" %02x ", pframe[pp]);
> -		pr_cont("\n");
> -	}
> -
>  	return _SUCCESS;
>  }

Please keep a blank line between the } and the return statement to
comply with kernel coding style.

ET

Re: [PATCH v2] staging: rtl8723bs: remove hardcoded dead debug code

[Greg KH]

On Fri, Jan 30, 2026 at 10:56:32PM +0530, SAJJA EASWAR SAI wrote:
> The debug code is guarded by a constant false condition and is never
> executed. Remove it to simplify the code. This also removes the now
> unused variable 'pattrib'.
> 
> Reported-by: kernel test robot <lkp@intel.com>

Did the robot report this original issue?  It just reported a problem
with your original patch.

> Closes: https://lore.kernel.org/oe-kbuild-all/202601302336.Jt5bRreu-lkp@intel.com/
> Signed-off-by: SAJJA EASWAR SAI <eshwarsajja20@gmail.com>

Please do not upper-case your full name.

> ---
>  drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 10 ----------
>  1 file changed, 10 deletions(-)

No version information?

thanks,

greg k-h