[PATCH] staging: rtl8723bs: replace msleep with usleep_range for small delays

[PATCH] staging: rtl8723bs: replace msleep with usleep_range for small delays

[Fu Zang]

From: Fu Zang <t1468150755@gmail.com>

The msleep() function is not recommended for delays shorter than 20ms
as it may sleep considerably longer than requested.

This patch replaces msleep(10) with usleep_range(10000, 11000) to
provide more precise delay control while allowing the timer subsystem
to coalesce wakeups.

Found by checkpatch.pl.

Signed-off-by: Fu Zang <t1468150755@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
index ef2d92b5588a..97c923015279 100644
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
@@ -215,7 +215,7 @@ void _rtw_free_evt_priv(struct	evt_priv *pevtpriv)
 {
 	_cancel_workitem_sync(&pevtpriv->c2h_wk);
 	while (pevtpriv->c2h_wk_alive)
-		msleep(10);
+		usleep_range(10000, 11000);
 
 	while (!rtw_cbuf_empty(pevtpriv->c2h_queue)) {
 		void *c2h = rtw_cbuf_pop(pevtpriv->c2h_queue);
-- 
2.43.0

Re: [PATCH] staging: rtl8723bs: replace msleep with usleep_range for small delays

[Ethan Tidmore]

On Fri Jan 30, 2026 at 7:08 AM CST, Fu Zang wrote:
> From: Fu Zang <t1468150755@gmail.com>
>
> The msleep() function is not recommended for delays shorter than 20ms
> as it may sleep considerably longer than requested.
>
> This patch replaces msleep(10) with usleep_range(10000, 11000) to
> provide more precise delay control while allowing the timer subsystem
> to coalesce wakeups.
>
> Found by checkpatch.pl.
>
> Signed-off-by: Fu Zang <t1468150755@gmail.com>

Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com>

Re: [PATCH] staging: rtl8723bs: replace msleep with usleep_range for small delays

[Ethan Tidmore]

On Fri Jan 30, 2026 at 7:08 AM CST, Fu Zang wrote:
> From: Fu Zang <t1468150755@gmail.com>
>
> The msleep() function is not recommended for delays shorter than 20ms
> as it may sleep considerably longer than requested.
>
> This patch replaces msleep(10) with usleep_range(10000, 11000) to
> provide more precise delay control while allowing the timer subsystem
> to coalesce wakeups.
>
> Found by checkpatch.pl.
>
> Signed-off-by: Fu Zang <t1468150755@gmail.com>

Apologies, I used the wrong tag in my previous response. I intended to provide a Reviewed-by tag for this patch.

Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>

Re: [PATCH] staging: rtl8723bs: replace msleep with usleep_range for small delays

[Greg KH]

On Fri, Jan 30, 2026 at 09:08:03PM +0800, Fu Zang wrote:
> From: Fu Zang <t1468150755@gmail.com>
> 
> The msleep() function is not recommended for delays shorter than 20ms
> as it may sleep considerably longer than requested.
> 
> This patch replaces msleep(10) with usleep_range(10000, 11000) to
> provide more precise delay control while allowing the timer subsystem
> to coalesce wakeups.
> 
> Found by checkpatch.pl.
> 
> Signed-off-by: Fu Zang <t1468150755@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index ef2d92b5588a..97c923015279 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -215,7 +215,7 @@ void _rtw_free_evt_priv(struct	evt_priv *pevtpriv)
>  {
>  	_cancel_workitem_sync(&pevtpriv->c2h_wk);
>  	while (pevtpriv->c2h_wk_alive)
> -		msleep(10);
> +		usleep_range(10000, 11000);
>  
>  	while (!rtw_cbuf_empty(pevtpriv->c2h_queue)) {
>  		void *c2h = rtw_cbuf_pop(pevtpriv->c2h_queue);
> -- 
> 2.43.0
> 
> 


Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You sent a patch that has been sent multiple times in the past, and is
  identical to ones that has been recently rejected.  Please always look
  at the mailing list traffic to determine if you are duplicating other
  people's work.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot