* [PATCH] staging: rtl8723bs: remove unnecessary boolean comparison
@ 2026-02-05 22:41 Nikolay Kulikov
2026-02-06 19:22 ` Ethan Tidmore
2026-02-14 19:09 ` [PATCH v2] " Nikolay Kulikov
0 siblings, 2 replies; 5+ messages in thread
From: Nikolay Kulikov @ 2026-02-05 22:41 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, Nikolay Kulikov
Remove explicit comprassion to true in boolean expression to follow
Linux kernel coding style.
Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_ap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
index 477fe238add4..82f05dacf41c 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ap.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
@@ -1157,7 +1157,7 @@ int rtw_acl_add_sta(struct adapter *padapter, u8 *addr)
paclnode = list_entry(plist, struct rtw_wlan_acl_node, list);
if (!memcmp(paclnode->addr, addr, ETH_ALEN)) {
- if (paclnode->valid == true) {
+ if (paclnode->valid) {
added = true;
break;
}
--
2.52.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: rtl8723bs: remove unnecessary boolean comparison
2026-02-05 22:41 [PATCH] staging: rtl8723bs: remove unnecessary boolean comparison Nikolay Kulikov
@ 2026-02-06 19:22 ` Ethan Tidmore
2026-02-08 9:00 ` Nikolay
2026-02-14 19:09 ` [PATCH v2] " Nikolay Kulikov
1 sibling, 1 reply; 5+ messages in thread
From: Ethan Tidmore @ 2026-02-06 19:22 UTC (permalink / raw)
To: Nikolay Kulikov, gregkh; +Cc: linux-staging
On Thu Feb 5, 2026 at 4:41 PM CST, Nikolay Kulikov wrote:
> Remove explicit comprassion to true in boolean expression to follow
> Linux kernel coding style.
You misspelt comparison as "comprassion".
>
> Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
> ---
Thanks,
ET
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: rtl8723bs: remove unnecessary boolean comparison
2026-02-06 19:22 ` Ethan Tidmore
@ 2026-02-08 9:00 ` Nikolay
0 siblings, 0 replies; 5+ messages in thread
From: Nikolay @ 2026-02-08 9:00 UTC (permalink / raw)
To: Ethan Tidmore; +Cc: gregkh, linux-staging
Thanks for the review!
I'll fix it and send v2.
Regards, Nikolay
пт, 6 февр. 2026 г. в 22:22, Ethan Tidmore <ethantidmore06@gmail.com>:
>
> On Thu Feb 5, 2026 at 4:41 PM CST, Nikolay Kulikov wrote:
> > Remove explicit comprassion to true in boolean expression to follow
> > Linux kernel coding style.
>
> You misspelt comparison as "comprassion".
>
> >
> > Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
> > ---
>
> Thanks,
>
> ET
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] staging: rtl8723bs: remove unnecessary boolean comparison
2026-02-05 22:41 [PATCH] staging: rtl8723bs: remove unnecessary boolean comparison Nikolay Kulikov
2026-02-06 19:22 ` Ethan Tidmore
@ 2026-02-14 19:09 ` Nikolay Kulikov
2026-02-14 19:58 ` Ethan Tidmore
1 sibling, 1 reply; 5+ messages in thread
From: Nikolay Kulikov @ 2026-02-14 19:09 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, ethantidmore06, Nikolay Kulikov
Remove explicit comparison to true in boolean expression to follow
Linux kernel coding style.
Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
---
Changes in v2:
- Fixed typo in commit message
drivers/staging/rtl8723bs/core/rtw_ap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
index 67197c7d4a4d..e23b86e66cb5 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ap.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
@@ -1157,7 +1157,7 @@ int rtw_acl_add_sta(struct adapter *padapter, u8 *addr)
paclnode = list_entry(plist, struct rtw_wlan_acl_node, list);
if (!memcmp(paclnode->addr, addr, ETH_ALEN)) {
- if (paclnode->valid == true) {
+ if (paclnode->valid) {
added = true;
break;
}
--
2.53.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] staging: rtl8723bs: remove unnecessary boolean comparison
2026-02-14 19:09 ` [PATCH v2] " Nikolay Kulikov
@ 2026-02-14 19:58 ` Ethan Tidmore
0 siblings, 0 replies; 5+ messages in thread
From: Ethan Tidmore @ 2026-02-14 19:58 UTC (permalink / raw)
To: Nikolay Kulikov, gregkh; +Cc: linux-staging, ethantidmore06
On Sat Feb 14, 2026 at 1:09 PM CST, Nikolay Kulikov wrote:
> Remove explicit comparison to true in boolean expression to follow
> Linux kernel coding style.
>
> Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
> ---
LGTM.
Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>
Thanks,
ET
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-02-14 19:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-05 22:41 [PATCH] staging: rtl8723bs: remove unnecessary boolean comparison Nikolay Kulikov
2026-02-06 19:22 ` Ethan Tidmore
2026-02-08 9:00 ` Nikolay
2026-02-14 19:09 ` [PATCH v2] " Nikolay Kulikov
2026-02-14 19:58 ` Ethan Tidmore
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox