From: "Ethan Tidmore" <ethantidmore06@gmail.com>
To: "Zeeshan Ahmad" <zeeshanahmad022019@gmail.com>,
"Parthiban Veerasooran" <parthiban.veerasooran@microchip.com>,
"Christian Gromm" <christian.gromm@microchip.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: "Dan Carpenter" <dan.carpenter@linaro.org>,
"Ethan Tidmore" <ethantidmore06@gmail.com>,
<linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] staging: most: dim2: convert pr_info/err/warn to dev_info/err/warn
Date: Fri, 06 Feb 2026 23:19:25 -0600 [thread overview]
Message-ID: <DG8H5N4CKTEO.JV3DLG7GUDZQ@gmail.com> (raw)
In-Reply-To: <20260207023433.3935-1-zeeshanahmad022019@gmail.com>
On Fri Feb 6, 2026 at 8:34 PM CST, Zeeshan Ahmad wrote:
> The dim2 driver currently uses generic pr_* logging macros. Hardware
> drivers should use the device-specific dev_* logging macros to provide
> better context in the system logs, especially in systems with multiple
> controller instances.
>
> This patch converts all applicable logging calls in dim2.c to use the
> proper device-specific APIs.
>
> Signed-off-by: Zeeshan Ahmad <zeeshanahmad022019@gmail.com>
> ---
> v3:
> - Removed "staging-next" and redundant "[PATCH]" from the subject line.
> - Shortened commit message lines to stay under 75 characters.
> - Added this changelog below the "---" as suggested by Ethan Tidmore.
> - Cleaned up temporary submission notes from the permanent commit body.
> v2:
> - Rebased against the staging-next branch.
> - Fixed CC list to include relevant maintainers.
>
LGTM.
Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>
Thanks,
ET
next prev parent reply other threads:[~2026-02-07 5:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-07 2:34 [PATCH v3] staging: most: dim2: convert pr_info/err/warn to dev_info/err/warn Zeeshan Ahmad
2026-02-07 5:19 ` Ethan Tidmore [this message]
2026-02-07 11:56 ` Greg Kroah-Hartman
2026-02-07 11:57 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DG8H5N4CKTEO.JV3DLG7GUDZQ@gmail.com \
--to=ethantidmore06@gmail.com \
--cc=christian.gromm@microchip.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=parthiban.veerasooran@microchip.com \
--cc=zeeshanahmad022019@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox