From: "Ethan Tidmore" <ethantidmore06@gmail.com>
To: "Artem Lytkin" <iprintercanon@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: <linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: vme_user: reorder NULL check after kzalloc in fake_crcsr_init
Date: Sat, 07 Feb 2026 20:33:44 -0600 [thread overview]
Message-ID: <DG989BZMHHLC.1FV459E6BHGLE@gmail.com> (raw)
In-Reply-To: <20260207215502.1961-1-iprintercanon@gmail.com>
On Sat Feb 7, 2026 at 3:55 PM CST, Artem Lytkin wrote:
> Move the NULL check for bridge->crcsr_kernel before its use in
> fake_ptr_to_pci(). While fake_ptr_to_pci() is a simple cast that
> handles NULL safely, using a value before validating it is a bad
> pattern that static analyzers flag and could become a real issue
> if fake_ptr_to_pci() changes in the future.
>
> Signed-off-by: Artem Lytkin <iprintercanon@gmail.com>
LGTM.
Next time, in your subject line, it's standard practice to end function
names with () to make it clear you're talking about a function.
Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>
Thanks,
ET
next prev parent reply other threads:[~2026-02-08 2:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-07 21:55 [PATCH] staging: vme_user: reorder NULL check after kzalloc in fake_crcsr_init Artem Lytkin
2026-02-08 2:33 ` Ethan Tidmore [this message]
2026-02-08 6:35 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DG989BZMHHLC.1FV459E6BHGLE@gmail.com \
--to=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=iprintercanon@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox