public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: "Ethan Tidmore" <ethantidmore06@gmail.com>
To: "Haroen Tmimi" <tmimiharoen@gmail.com>, <gregkh@linuxfoundation.org>
Cc: <linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] staging: rtl8723bs: remove explicit comparisons to false in rtw_ap.c
Date: Tue, 10 Feb 2026 12:54:16 -0600	[thread overview]
Message-ID: <DGBID683QZLL.275K62PPUD5D8@gmail.com> (raw)
In-Reply-To: <20260210161628.42130-1-tmimiharoen@gmail.com>

On Tue Feb 10, 2026 at 10:16 AM CST, Haroen Tmimi wrote:
> Fix checkpatch.pl checks regarding error prone boolean comparisons.
> Replace explicit comparisons to false with the logical NOT operator
> to improve readability and match kernel coding style.
>
> These instances were remaining after recent cleanups in this file.
>
> Signed-off-by: Haroen Tmimi <tmimiharoen@gmail.com>

Please slow down, there is no rush here. Wait 24h between submitting
revisions. This gives a chance for other people to review your code.

LGTM.

Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>

Thanks,

ET

  reply	other threads:[~2026-02-10 19:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-10 16:16 [PATCH v2] staging: rtl8723bs: remove explicit comparisons to false in rtw_ap.c Haroen Tmimi
2026-02-10 18:54 ` Ethan Tidmore [this message]
2026-02-10 18:58   ` Haroen Tmimi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DGBID683QZLL.275K62PPUD5D8@gmail.com \
    --to=ethantidmore06@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=tmimiharoen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox