[PATCH v2] staging: rtl8723bs: remove explicit comparisons to false in rtw_ap.c

[PATCH v2] staging: rtl8723bs: remove explicit comparisons to false in rtw_ap.c

[Haroen Tmimi]

Fix checkpatch.pl checks regarding error prone boolean comparisons.
Replace explicit comparisons to false with the logical NOT operator
to improve readability and match kernel coding style.

These instances were remaining after recent cleanups in this file.

Signed-off-by: Haroen Tmimi <tmimiharoen@gmail.com>
---
Changes in v2:
Fixed syntax error: Moved NOT operator '!' to the correct position.

 drivers/staging/rtl8723bs/core/rtw_ap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
index ebe73abab892..0192543cdec0 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ap.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
@@ -1013,10 +1013,10 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
 
 		rtw_ht_use_default_setting(padapter);
 
-		if (pmlmepriv->htpriv.sgi_20m == false)
+		if (!pmlmepriv->htpriv.sgi_20m)
 			pht_cap->cap_info &= cpu_to_le16(~(IEEE80211_HT_CAP_SGI_20));
 
-		if (pmlmepriv->htpriv.sgi_40m == false)
+		if (!pmlmepriv->htpriv.sgi_40m)
 			pht_cap->cap_info &= cpu_to_le16(~(IEEE80211_HT_CAP_SGI_40));
 
 		if (!TEST_FLAG(pmlmepriv->htpriv.ldpc_cap, LDPC_HT_ENABLE_RX))
-- 
2.53.0

Re: [PATCH v2] staging: rtl8723bs: remove explicit comparisons to false in rtw_ap.c

[Ethan Tidmore]

On Tue Feb 10, 2026 at 10:16 AM CST, Haroen Tmimi wrote:
> Fix checkpatch.pl checks regarding error prone boolean comparisons.
> Replace explicit comparisons to false with the logical NOT operator
> to improve readability and match kernel coding style.
>
> These instances were remaining after recent cleanups in this file.
>
> Signed-off-by: Haroen Tmimi <tmimiharoen@gmail.com>

Please slow down, there is no rush here. Wait 24h between submitting
revisions. This gives a chance for other people to review your code.

LGTM.

Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>

Thanks,

ET

Re: [PATCH v2] staging: rtl8723bs: remove explicit comparisons to false in rtw_ap.c

[Haroen Tmimi]

I tend to work in a dedicated block of some hours, so my apologies for
rushing. I will keep it in mind for next time.
Thanks for all the help.

Kind regards,

Haroen Tmimi

Op di 10 feb 2026 om 19:54 schreef Ethan Tidmore <ethantidmore06@gmail.com>:
>
> On Tue Feb 10, 2026 at 10:16 AM CST, Haroen Tmimi wrote:
> > Fix checkpatch.pl checks regarding error prone boolean comparisons.
> > Replace explicit comparisons to false with the logical NOT operator
> > to improve readability and match kernel coding style.
> >
> > These instances were remaining after recent cleanups in this file.
> >
> > Signed-off-by: Haroen Tmimi <tmimiharoen@gmail.com>
>
> Please slow down, there is no rush here. Wait 24h between submitting
> revisions. This gives a chance for other people to review your code.
>
> LGTM.
>
> Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>
>
> Thanks,
>
> ET