From: "Ethan Tidmore" <ethantidmore06@gmail.com>
To: "Ofek Almog" <ofekalm100@gmail.com>, <gregkh@linuxfoundation.org>
Cc: <linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
<s9430939@naver.com>, <architanant5@gmail.com>,
<andriy.shevchenko@intel.com>
Subject: Re: [PATCH] staging: rtl8723bs: replace msleep with usleep_range
Date: Sat, 14 Feb 2026 12:11:16 -0600 [thread overview]
Message-ID: <DGEVYFG99X27.1U7FPTF3YE7V6@gmail.com> (raw)
In-Reply-To: <20260214173139.49094-1-ofekalm100@gmail.com>
On Sat Feb 14, 2026 at 11:31 AM CST, Ofek Almog wrote:
> This patch replaces msleep(10) with usleep_range(10000, 11000) to provide
> more precise delay handling while allowing the timer subsystem to coalesce
> timers efficiently.
>
> Signed-off-by: Ofek Almog <ofekalm100@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index b2e7f479f72b..3f5b3ca2066d 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -214,7 +214,7 @@ void _rtw_free_evt_priv(struct evt_priv *pevtpriv)
> {
> _cancel_workitem_sync(&pevtpriv->c2h_wk);
> while (pevtpriv->c2h_wk_alive)
> - msleep(10);
> + usleep_range(10000, 11000);
>
> while (!rtw_cbuf_empty(pevtpriv->c2h_queue)) {
> void *c2h = rtw_cbuf_pop(pevtpriv->c2h_queue);
Shouldn't we be using fsleep() now instead of replacing msleep() with
usleep_range() when the time is sub 20ms?
I feel like I read Andy Shevchenko mention this elsewhere.
Thanks,
ET
next prev parent reply other threads:[~2026-02-14 18:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-14 17:31 [PATCH] staging: rtl8723bs: replace msleep with usleep_range Ofek Almog
2026-02-14 18:11 ` Ethan Tidmore [this message]
2026-02-14 18:24 ` Andy Shevchenko
2026-02-14 19:23 ` Ofek Almog
2026-02-15 6:52 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2026-03-19 19:54 [PATCH] staging: rtl8723bs: Replace " AyushMukkanwar
2026-03-19 20:23 ` Ethan Tidmore
2026-03-20 7:42 ` Andy Shevchenko
2026-03-14 5:11 [PATCH] staging: rtl8723bs: replace " Marcos Andrade
2026-03-14 20:56 ` Ethan Tidmore
2026-03-09 0:40 sluisr
2026-03-09 13:33 ` Bryant Boatright
2026-03-09 16:01 ` Greg KH
2026-02-10 5:58 Vo Thanh Cong
2026-02-10 6:37 ` Greg Kroah-Hartman
2026-02-09 12:07 Ethan Lam
2026-02-09 12:35 ` Greg KH
2026-02-08 12:15 Miguel Angel De la Vega Rodriguez
2026-02-08 14:35 ` Greg Kroah-Hartman
2026-01-10 20:44 Işıkhan IŞIK
2026-01-11 12:49 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DGEVYFG99X27.1U7FPTF3YE7V6@gmail.com \
--to=ethantidmore06@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=architanant5@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=ofekalm100@gmail.com \
--cc=s9430939@naver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox