From: Hardik Phalet <hardik.phalet@pm.me>
To: Hardik Phalet <hardik.phalet@pm.me>, linux-staging@lists.linux.dev
Cc: vaibhav.sr@gmail.com, mgreer@animalcreek.com, johan@kernel.org,
elder@kernel.org, gregkh@linuxfoundation.org,
greybus-dev@lists.linaro.org, linux-kernel@vger.kernel.org
Subject: [PATCH v1 2/2] staging: greybus: audio: drop stale TODO in module release
Date: Fri, 20 Feb 2026 05:45:44 +0000 [thread overview]
Message-ID: <DGJJURREST2E.1YYACU06X3V9C@pm.me> (raw)
In-Reply-To: <DGJJRT1BJV4H.1JGMNMC4SGKT7@pm.me>
[-- Attachment #1: Type: text/plain, Size: 13 bytes --]
Empty Message
[-- Attachment #2: 0002-staging-greybus-audio-drop-stale-TODO-in-module-rele.patch --]
[-- Type: text/x-patch, Size: 1117 bytes --]
From b381767672023234e6d18482a7b68aeb78fdf2b9 Mon Sep 17 00:00:00 2001
From: Hardik Phalet <hardik.phalet@pm.me>
Date: Fri, 20 Feb 2026 10:46:50 +0530
Subject: [PATCH v1 2/2] staging: greybus: audio: drop stale TODO in module
release
Modules are removed from modules_list in gb_audio_manager_remove() and
gb_audio_manager_remove_all() before kobject_put(). The TODO suggesting
list deletion in the kobject release callback is stale and misleading.
Signed-off-by: Hardik Phalet <hardik.phalet@pm.me>
---
drivers/staging/greybus/audio_manager_module.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/staging/greybus/audio_manager_module.c
index 4a4dfb42f50f..b1dd3da9f57c 100644
--- a/drivers/staging/greybus/audio_manager_module.c
+++ b/drivers/staging/greybus/audio_manager_module.c
@@ -69,7 +69,6 @@ static void gb_audio_module_release(struct kobject *kobj)
struct gb_audio_manager_module *module = to_gb_audio_module(kobj);
pr_info("Destroying audio module #%d\n", module->id);
- /* TODO -> delete from list */
kfree(module);
}
--
2.53.0
next prev parent reply other threads:[~2026-02-20 5:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 5:41 [PATCH v1 0/2] staging: greybus: audio: small fixes Hardik Phalet
2026-02-20 5:44 ` [PATCH v1 1/2] staging: greybus: audio: fix NULL dereference in gb_audio_manager_get_module() Hardik Phalet
2026-02-20 6:07 ` Greg KH
2026-02-20 8:03 ` Dan Carpenter
2026-02-20 5:45 ` Hardik Phalet [this message]
2026-02-20 5:51 ` [PATCH v1 0/2] staging: greybus: audio: small fixes Hardik Phalet
2026-02-20 6:07 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DGJJURREST2E.1YYACU06X3V9C@pm.me \
--to=hardik.phalet@pm.me \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mgreer@animalcreek.com \
--cc=vaibhav.sr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox