public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: "Ethan Tidmore" <ethantidmore06@gmail.com>
To: "Nikolay Kulikov" <nikolayof23@gmail.com>,
	"Ethan Tidmore" <ethantidmore06@gmail.com>
Cc: <gregkh@linuxfoundation.org>, <linux-staging@lists.linux.dev>
Subject: Re: [PATCH] staging: rtl8723bs: fix spaces around binary operators
Date: Fri, 20 Feb 2026 12:21:50 -0600	[thread overview]
Message-ID: <DGJZXS0ZURKI.13IEI2NXCMESQ@gmail.com> (raw)
In-Reply-To: <aZbVOzEgj6ljtfqf@archlinux>

On Thu Feb 19, 2026 at 3:17 AM CST, Nikolay Kulikov wrote:
> On Wed, Feb 18, 2026 at 12:34:56PM -0600, Ethan Tidmore wrote:
>> 
>> Logical continuations should be on the previous line:
>> 
>> while (cnt < in_len) {
>> 	if (eid == in_ie[cnt] &&
>> 		(!oui || !memcmp(&in_ie[cnt + 2], oui, oui_len))) {
>> 
> ...
>> 
>> Alignment should match open parenthesis:
>> 
>> if ((*wpa_ie != WLAN_EID_VENDOR_SPECIFIC) || (*(wpa_ie + 1) != (u8)(wpa_ie_len - 2)) ||
>> 	(memcmp(wpa_ie+2, RTW_WPA_OUI_TYPE, WPA_SELECTOR_LEN))) {
>
> Hi, i saw these issues when i was fixing the spaces, but i intentionally
> didn't fix the indentation to avoid merging different changes into one
> patch. I'm ready to send a sepatate patch with indentation fixes.

I understand, but here since you're already editing the line, it's best to
just fix both whitespace problems at the same time.

Thanks, 

ET

  reply	other threads:[~2026-02-20 18:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-18 11:30 [PATCH] staging: rtl8723bs: fix spaces around binary operators Nikolay Kulikov
2026-02-18 18:34 ` Ethan Tidmore
2026-02-19  9:17   ` Nikolay Kulikov
2026-02-20 18:21     ` Ethan Tidmore [this message]
2026-02-21 11:02       ` Nikolay Kulikov
2026-02-19 17:14 ` [PATCH v2] " Nikolay Kulikov
2026-02-21 17:24 ` [PATCH v3] " Nikolay Kulikov
2026-02-21 18:57   ` Ethan Tidmore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DGJZXS0ZURKI.13IEI2NXCMESQ@gmail.com \
    --to=ethantidmore06@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=nikolayof23@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox