From: "Ethan Tidmore" <ethantidmore06@gmail.com>
To: "Dhyan K Prajapati" <dhyan19022009@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: <linux-staging@lists.linux.dev>, "Jason Donenfeld" <Jason@zx2c4.com>
Subject: Re: [PATCH] staging: rtl8723bs: fix function header alignment
Date: Thu, 26 Feb 2026 20:16:38 -0600 [thread overview]
Message-ID: <DGPDSKXS6NJH.3MWCJMW7KLGW4@gmail.com> (raw)
In-Reply-To: <20260225085747.9639-1-dhyan19022009@gmail.com>
On Wed Feb 25, 2026 at 2:57 AM CST, Dhyan K Prajapati wrote:
> fixed header alignment in hal_sdio_get_cmd_addr_8723b that violated
> kernel coding style, cleaned the header by pulling arguments onto the
> same line.
>
> Signed-off-by: Dhyan K Prajapati <dhyan19022009@gmail.com>
> ---
LGTM. However, next time say parameter alignment instead of header. Was
a little confused what you meant at first until I read your subject
line.
Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>
Thanks,
ET
next prev parent reply other threads:[~2026-02-27 2:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 8:57 [PATCH] staging: rtl8723bs: fix function header alignment Dhyan K Prajapati
2026-02-27 2:16 ` Ethan Tidmore [this message]
2026-02-27 4:57 ` Dhyan K Prajapati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DGPDSKXS6NJH.3MWCJMW7KLGW4@gmail.com \
--to=ethantidmore06@gmail.com \
--cc=Jason@zx2c4.com \
--cc=dhyan19022009@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox