* [PATCH] staging: rtl8723bs: fix function header alignment
@ 2026-02-25 8:57 Dhyan K Prajapati
2026-02-27 2:16 ` Ethan Tidmore
0 siblings, 1 reply; 3+ messages in thread
From: Dhyan K Prajapati @ 2026-02-25 8:57 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-staging, Jason Donenfeld, Dhyan K Prajapati
fixed header alignment in hal_sdio_get_cmd_addr_8723b that violated
kernel coding style, cleaned the header by pulling arguments onto the
same line.
Signed-off-by: Dhyan K Prajapati <dhyan19022009@gmail.com>
---
drivers/staging/rtl8723bs/hal/sdio_ops.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c
index c9cb20c61..18eb50c6f 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_ops.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c
@@ -13,12 +13,8 @@
/* */
/* Creadted by Roger, 2011.01.31. */
/* */
-static void hal_sdio_get_cmd_addr_8723b(
- struct adapter *adapter,
- u8 device_id,
- u32 addr,
- u32 *cmdaddr
-)
+static void hal_sdio_get_cmd_addr_8723b(struct adapter *adapter, u8 device_id,
+ u32 addr, u32 *cmdaddr)
{
switch (device_id) {
case SDIO_LOCAL_DEVICE_ID:
--
2.53.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] staging: rtl8723bs: fix function header alignment
2026-02-25 8:57 [PATCH] staging: rtl8723bs: fix function header alignment Dhyan K Prajapati
@ 2026-02-27 2:16 ` Ethan Tidmore
2026-02-27 4:57 ` Dhyan K Prajapati
0 siblings, 1 reply; 3+ messages in thread
From: Ethan Tidmore @ 2026-02-27 2:16 UTC (permalink / raw)
To: Dhyan K Prajapati, Greg Kroah-Hartman; +Cc: linux-staging, Jason Donenfeld
On Wed Feb 25, 2026 at 2:57 AM CST, Dhyan K Prajapati wrote:
> fixed header alignment in hal_sdio_get_cmd_addr_8723b that violated
> kernel coding style, cleaned the header by pulling arguments onto the
> same line.
>
> Signed-off-by: Dhyan K Prajapati <dhyan19022009@gmail.com>
> ---
LGTM. However, next time say parameter alignment instead of header. Was
a little confused what you meant at first until I read your subject
line.
Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>
Thanks,
ET
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: rtl8723bs: fix function header alignment
2026-02-27 2:16 ` Ethan Tidmore
@ 2026-02-27 4:57 ` Dhyan K Prajapati
0 siblings, 0 replies; 3+ messages in thread
From: Dhyan K Prajapati @ 2026-02-27 4:57 UTC (permalink / raw)
To: Ethan Tidmore; +Cc: Greg Kroah-Hartman, linux-staging, Jason Donenfeld
On Thu, Feb 26, 2026 at 08:16:38PM -0600, Ethan Tidmore wrote:
>On Wed Feb 25, 2026 at 2:57 AM CST, Dhyan K Prajapati wrote:
>> fixed header alignment in hal_sdio_get_cmd_addr_8723b that violated
>> kernel coding style, cleaned the header by pulling arguments onto the
>> same line.
>>
>> Signed-off-by: Dhyan K Prajapati <dhyan19022009@gmail.com>
>> ---
>
>LGTM. However, next time say parameter alignment instead of header. Was
>a little confused what you meant at first until I read your subject
>line.
>
>Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>
>
>Thanks,
>
>ET
seconded, i'll keep that in mind the next time.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-02-27 4:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-25 8:57 [PATCH] staging: rtl8723bs: fix function header alignment Dhyan K Prajapati
2026-02-27 2:16 ` Ethan Tidmore
2026-02-27 4:57 ` Dhyan K Prajapati
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox