Re: [PATCH] staging: rtl8723bs: remove unused 'ratelen' parameter from rtw_check_network_type()

["Ethan Tidmore" <ethantidmore06@gmail.com>]

On Fri Feb 27, 2026 at 11:38 AM CST, Ethan Tidmore wrote:
> On Fri Feb 27, 2026 at 9:26 AM CST, Nikolay Kulikov wrote:
>> On Thu, Feb 26, 2026 at 09:47:57AM -0600, Ethan Tidmore wrote:
>>> On Thu Feb 26, 2026 at 8:10 AM CST, Nikolay Kulikov wrote:
>>> > The rtw_check_network_type() function takes a 'ratelen' parameter, but
>>> > does not use it in any way. Also remove the local variable in rtw_ap.c
>>> > created just to pass a value to this unused parameter.
>>> >
>>> > Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
>>> > ---
>>> 
>>> ...
>>> 
>>> 
>>> > @@ -890,7 +887,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
>>> >  		support_rate_num += ie_len;
>>> >  	}
>>> >  
>>> > -	network_type = rtw_check_network_type(support_rate, support_rate_num, channel);
>>> > +	network_type = rtw_check_network_type(support_rate, channel);
>>> 
>>> I think you can delete support_rate_num in this function too.
>>
>> Is it possible to remove it completely? It's used as a temporary buffer
>> for 'ie_len', so perhaps just the last line that increments
>> 'support_rate_num' can be removed:
>>
>>> >  		support_rate_num += ie_len;
>>
>> since this value is not used anywhere below.
>
> You are right, we can remove support_rate_num entirely, but removing
> this would be nice.

can't*

>
> Thanks,
>
> ET