From: "Ethan Tidmore" <ethantidmore06@gmail.com>
To: "Albab Hasan" <albabhasan276@gmail.com>, <linux-staging@lists.linux.dev>
Cc: <gregkh@linuxfoundation.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: vme_user: remove unimplemented #if 0 code blocks
Date: Sun, 01 Mar 2026 13:25:33 -0600 [thread overview]
Message-ID: <DGROXGWX17G4.1782487P7HLCT@gmail.com> (raw)
In-Reply-To: <20260228153809.15398-1-albabhasan276@gmail.com>
On Sat Feb 28, 2026 at 9:38 AM CST, Albab Hasan wrote:
> Remove dead code in #if 0 blocks from struct vme_master
> and struct vme_slave. these were never implemented or
> compiled in.
>
> checkpatch.pl reports:
>
> WARNING: Consider removing the code enclosed by this #if 0 and its #endif
>
> No functional changes.
>
> Signed-off-by: Albab Hasan <albabhasan276@gmail.com>
> ---
LGTM.
Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>
Thanks,
ET
prev parent reply other threads:[~2026-03-01 19:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-28 15:38 [PATCH] staging: vme_user: remove unimplemented #if 0 code blocks Albab Hasan
2026-03-01 19:25 ` Ethan Tidmore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DGROXGWX17G4.1782487P7HLCT@gmail.com \
--to=ethantidmore06@gmail.com \
--cc=albabhasan276@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox