* [PATCH 1/2] staging: rtl8723bs: remove unused rtl8192c_query_rx_desc_status declaration
@ 2026-03-13 19:06 Azamat Rakhim
2026-03-13 19:06 ` [PATCH 2/2] staging: rtl8723bs: remove unused rtl8192c_translate_rx_signal_stuff declaration Azamat Rakhim
2026-03-13 20:38 ` [PATCH 1/2] staging: rtl8723bs: remove unused rtl8192c_query_rx_desc_status declaration Ethan Tidmore
0 siblings, 2 replies; 4+ messages in thread
From: Azamat Rakhim @ 2026-03-13 19:06 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, Azamat Rakhim
The function rtl8192c_query_rx_desc_status is declared in rtl8192c_recv.h
but never defined or called anywhere in the driver.
Signed-off-by: Azamat Rakhim <azamatrakhim8@gmail.com>
---
drivers/staging/rtl8723bs/include/rtl8192c_recv.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/include/rtl8192c_recv.h b/drivers/staging/rtl8723bs/include/rtl8192c_recv.h
index 9664758e21be..abc7a7c418af 100644
--- a/drivers/staging/rtl8723bs/include/rtl8192c_recv.h
+++ b/drivers/staging/rtl8723bs/include/rtl8192c_recv.h
@@ -34,8 +34,6 @@ struct phy_stat {
/* Rx smooth factor */
#define Rx_Smooth_Factor (20)
-
-void rtl8192c_translate_rx_signal_stuff(union recv_frame *precvframe, struct phy_stat *pphy_status);
void rtl8192c_query_rx_desc_status(union recv_frame *precvframe, struct recv_stat *pdesc);
#endif
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] staging: rtl8723bs: remove unused rtl8192c_translate_rx_signal_stuff declaration
2026-03-13 19:06 [PATCH 1/2] staging: rtl8723bs: remove unused rtl8192c_query_rx_desc_status declaration Azamat Rakhim
@ 2026-03-13 19:06 ` Azamat Rakhim
2026-03-16 8:33 ` Dan Carpenter
2026-03-13 20:38 ` [PATCH 1/2] staging: rtl8723bs: remove unused rtl8192c_query_rx_desc_status declaration Ethan Tidmore
1 sibling, 1 reply; 4+ messages in thread
From: Azamat Rakhim @ 2026-03-13 19:06 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, Azamat Rakhim
The function rtl8192c_translate_rx_signal_stuff is declared in rtl8192c_recv.h
but never defined or called anywhere in the driver
Signed-off-by: Azamat Rakhim <azamatrakhim8@gmail.com>
---
drivers/staging/rtl8723bs/include/rtl8192c_recv.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/include/rtl8192c_recv.h b/drivers/staging/rtl8723bs/include/rtl8192c_recv.h
index abc7a7c418af..1a04c3454b80 100644
--- a/drivers/staging/rtl8723bs/include/rtl8192c_recv.h
+++ b/drivers/staging/rtl8723bs/include/rtl8192c_recv.h
@@ -34,6 +34,5 @@ struct phy_stat {
/* Rx smooth factor */
#define Rx_Smooth_Factor (20)
-void rtl8192c_query_rx_desc_status(union recv_frame *precvframe, struct recv_stat *pdesc);
#endif
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] staging: rtl8723bs: remove unused rtl8192c_translate_rx_signal_stuff declaration
2026-03-13 19:06 ` [PATCH 2/2] staging: rtl8723bs: remove unused rtl8192c_translate_rx_signal_stuff declaration Azamat Rakhim
@ 2026-03-16 8:33 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2026-03-16 8:33 UTC (permalink / raw)
To: Azamat Rakhim; +Cc: gregkh, linux-staging, linux-kernel
On Sat, Mar 14, 2026 at 12:06:58AM +0500, Azamat Rakhim wrote:
> The function rtl8192c_translate_rx_signal_stuff is declared in rtl8192c_recv.h
> but never defined or called anywhere in the driver
>
> Signed-off-by: Azamat Rakhim <azamatrakhim8@gmail.com>
> ---
> drivers/staging/rtl8723bs/include/rtl8192c_recv.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/include/rtl8192c_recv.h b/drivers/staging/rtl8723bs/include/rtl8192c_recv.h
> index abc7a7c418af..1a04c3454b80 100644
> --- a/drivers/staging/rtl8723bs/include/rtl8192c_recv.h
> +++ b/drivers/staging/rtl8723bs/include/rtl8192c_recv.h
> @@ -34,6 +34,5 @@ struct phy_stat {
> /* Rx smooth factor */
> #define Rx_Smooth_Factor (20)
>
> -void rtl8192c_query_rx_desc_status(union recv_frame *precvframe, struct recv_stat *pdesc);
>
Need to delete the blank line as well.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] staging: rtl8723bs: remove unused rtl8192c_query_rx_desc_status declaration
2026-03-13 19:06 [PATCH 1/2] staging: rtl8723bs: remove unused rtl8192c_query_rx_desc_status declaration Azamat Rakhim
2026-03-13 19:06 ` [PATCH 2/2] staging: rtl8723bs: remove unused rtl8192c_translate_rx_signal_stuff declaration Azamat Rakhim
@ 2026-03-13 20:38 ` Ethan Tidmore
1 sibling, 0 replies; 4+ messages in thread
From: Ethan Tidmore @ 2026-03-13 20:38 UTC (permalink / raw)
To: Azamat Rakhim, gregkh; +Cc: linux-staging, linux-kernel
On Fri Mar 13, 2026 at 2:06 PM CDT, Azamat Rakhim wrote:
> The function rtl8192c_query_rx_desc_status is declared in rtl8192c_recv.h
> but never defined or called anywhere in the driver.
>
> Signed-off-by: Azamat Rakhim <azamatrakhim8@gmail.com>
> ---
Looking at rtl8192c_recv.h, it looks like you can rather easily just
delete the entire header file. Just put the things that are used
elsewhere in the driver into rtl8723b_recv.h.
Thanks,
ET
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-03-16 8:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-13 19:06 [PATCH 1/2] staging: rtl8723bs: remove unused rtl8192c_query_rx_desc_status declaration Azamat Rakhim
2026-03-13 19:06 ` [PATCH 2/2] staging: rtl8723bs: remove unused rtl8192c_translate_rx_signal_stuff declaration Azamat Rakhim
2026-03-16 8:33 ` Dan Carpenter
2026-03-13 20:38 ` [PATCH 1/2] staging: rtl8723bs: remove unused rtl8192c_query_rx_desc_status declaration Ethan Tidmore
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox