* [PATCH] staging: rtl8723bs: Replace msleep() with fsleep()
@ 2026-03-14 21:54 Marcos Andrade
2026-03-15 1:18 ` Ethan Tidmore
0 siblings, 1 reply; 2+ messages in thread
From: Marcos Andrade @ 2026-03-14 21:54 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, ethantidmore06, Marcos Andrade
Replace msleep(10) with fsleep(10 * USEC_PER_MSEC) in _rtw_init_xmit_priv().
fsleep() is the new standard API for delays, as it automatically chooses
the best sleep method based on the duration.
Suggested-by: Ethan Tidmore <ethantidmore06@gmail.com>
Signed-off-by: Marcos Andrade <marcosandrade95963@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_xmit.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c
index 4062fe0c1..dab16851f 100644
--- a/drivers/staging/rtl8723bs/core/rtw_xmit.c
+++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c
@@ -5,6 +5,7 @@
*
******************************************************************************/
#include <drv_types.h>
+#include <linux/delay.h>
#include <linux/if_ether.h>
static u8 P802_1H_OUI[P80211_OUI_LEN] = { 0x00, 0x00, 0xf8 };
@@ -129,7 +130,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter)
/* Tx buf allocation may fail sometimes, so sleep and retry. */
res = rtw_os_xmit_resource_alloc(padapter, pxmitbuf, (MAX_XMITBUF_SZ + XMITBUF_ALIGN_SZ), true);
if (res == _FAIL) {
- msleep(10);
+ fsleep(10 * USEC_PER_MSEC);
res = rtw_os_xmit_resource_alloc(padapter, pxmitbuf, (MAX_XMITBUF_SZ + XMITBUF_ALIGN_SZ), true);
if (res == _FAIL)
goto exit;
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: rtl8723bs: Replace msleep() with fsleep()
2026-03-14 21:54 [PATCH] staging: rtl8723bs: Replace msleep() with fsleep() Marcos Andrade
@ 2026-03-15 1:18 ` Ethan Tidmore
0 siblings, 0 replies; 2+ messages in thread
From: Ethan Tidmore @ 2026-03-15 1:18 UTC (permalink / raw)
To: Marcos Andrade, gregkh; +Cc: linux-staging, linux-kernel, ethantidmore06
On Sat Mar 14, 2026 at 4:54 PM CDT, Marcos Andrade wrote:
> Replace msleep(10) with fsleep(10 * USEC_PER_MSEC) in _rtw_init_xmit_priv().
> fsleep() is the new standard API for delays, as it automatically chooses
> the best sleep method based on the duration.
>
> Suggested-by: Ethan Tidmore <ethantidmore06@gmail.com>
> Signed-off-by: Marcos Andrade <marcosandrade95963@gmail.com>
> ---
Since this patch requires the other patch this needs to be a patch
series. Because since you submitted them as just single patches this one
will not apply on its own.
A patch series typically has a cover letter explaining what the patches
do and you link them together using git send-email.
Thanks,
ET
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-15 1:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-14 21:54 [PATCH] staging: rtl8723bs: Replace msleep() with fsleep() Marcos Andrade
2026-03-15 1:18 ` Ethan Tidmore
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox