[PATCH v4] staging: rtl8723bs: remove unnecessary braces for single statement

[PATCH v4] staging: rtl8723bs: remove unnecessary braces for single statement

[Marcos Andrade]

Remove unnecessary braces for a single statement block in an if
condition to comply with the Linux kernel coding style.
This resolves a checkpatch.pl warning.

Signed-off-by: Marcos Andrade <marcosandrade95963@gmail.com>
---
Changes in v3:
- Add missing change log as requested by GKH.

Changes in v2:
- Remove unnecessary braces in os_dep/sdio_intf.c to comply with 
  the Linux kernel coding style.

 drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
index d664e2549..a86252cca 100644
--- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
+++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
@@ -146,9 +146,8 @@ static void sdio_deinit(struct dvobj_priv *dvobj)
 		sdio_claim_host(func);
 		sdio_disable_func(func);
 
-		if (dvobj->irq_alloc) {
+		if (dvobj->irq_alloc)
 			sdio_release_irq(func);
-		}
 
 		sdio_release_host(func);
 	}
-- 
2.53.0

Re: [PATCH v4] staging: rtl8723bs: remove unnecessary braces for single statement

[Marcos Andrade]

Hi all,

Apologies for missing the changelog in this v4 submission.

For clarity, the only change from v3 is the correction of the typo
('checkpacth.pl' -> 'checkpatch.pl') in the commit message, as
pointed out by Ethan. The code remains unchanged.

Thanks,
Marcos.

On Sat, Mar 14, 2026 at 6:13 PM Marcos Andrade
<marcosandrade95963@gmail.com> wrote:
>
> Remove unnecessary braces for a single statement block in an if
> condition to comply with the Linux kernel coding style.
> This resolves a checkpatch.pl warning.
>
> Signed-off-by: Marcos Andrade <marcosandrade95963@gmail.com>
> ---
> Changes in v3:
> - Add missing change log as requested by GKH.
>
> Changes in v2:
> - Remove unnecessary braces in os_dep/sdio_intf.c to comply with
>   the Linux kernel coding style.
>
>  drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> index d664e2549..a86252cca 100644
> --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> @@ -146,9 +146,8 @@ static void sdio_deinit(struct dvobj_priv *dvobj)
>                 sdio_claim_host(func);
>                 sdio_disable_func(func);
>
> -               if (dvobj->irq_alloc) {
> +               if (dvobj->irq_alloc)
>                         sdio_release_irq(func);
> -               }
>
>                 sdio_release_host(func);
>         }
> --
> 2.53.0
>

Re: [PATCH v4] staging: rtl8723bs: remove unnecessary braces for single statement

[Ethan Tidmore]

On Sat Mar 14, 2026 at 4:13 PM CDT, Marcos Andrade wrote:
> Remove unnecessary braces for a single statement block in an if
> condition to comply with the Linux kernel coding style.
> This resolves a checkpatch.pl warning.
>
> Signed-off-by: Marcos Andrade <marcosandrade95963@gmail.com>
> ---

I'm not sure if Greg won't mind the v4 isn't here, but since you caught
it in a follow up email, this looks good to me.

Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>

Thanks,

ET