From: "Ethan Tidmore" <ethantidmore06@gmail.com>
To: "Marcos Andrade" <marcosandrade95963@gmail.com>,
<gregkh@linuxfoundation.org>
Cc: <linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
<ethantidmore06@gmail.com>
Subject: Re: [PATCH v3 2/2] staging: rtl8723bs: Replace msleep() with fsleep()
Date: Sun, 15 Mar 2026 12:34:29 -0500 [thread overview]
Message-ID: <DH3JC2D71X1Z.O5DGZVUH99G2@gmail.com> (raw)
In-Reply-To: <20260315020949.50149-3-marcosandrade95963@gmail.com>
On Sat Mar 14, 2026 at 9:09 PM CDT, Marcos Andrade wrote:
> Replace msleep(10) with fsleep(10 * USEC_PER_MSEC) in _rtw_init_xmit_priv().
> fsleep() is the new standard API for delays, as it automatically chooses
> the best sleep method based on the duration.
>
> Suggested-by: Ethan Tidmore <ethantidmore06@gmail.com>
> Signed-off-by: Marcos Andrade <marcosandrade95963@gmail.com>
> ---
$ ./scripts/checkpatch.pl --strict -g HEAD
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#6:
Replace msleep(10) with fsleep(10 * USEC_PER_MSEC) in _rtw_init_xmit_priv().
Remember to always run "./scripts/checkpatch.pl --strict <patch>" before
sending a patch off to catch things like this.
Thanks,
ET
prev parent reply other threads:[~2026-03-15 17:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-15 2:09 [PATCH v3 0/2] staging: rtl8723bs: Cleanups for rtw_xmit.c Marcos Andrade
2026-03-15 2:09 ` [PATCH v3 1/2] staging: rtl8723bs: Replace network magic numbers with EtherType macros Marcos Andrade
2026-03-15 2:09 ` [PATCH v3 2/2] staging: rtl8723bs: Replace msleep() with fsleep() Marcos Andrade
2026-03-15 17:34 ` Ethan Tidmore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DH3JC2D71X1Z.O5DGZVUH99G2@gmail.com \
--to=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=marcosandrade95963@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox