From: "Ethan Tidmore" <ethantidmore06@gmail.com>
To: "Marcos Andrade" <marcosandrade95963@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Ethan Tidmore" <ethantidmore06@gmail.com>
Cc: <linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 0/2] staging: rtl8723bs: Cleanups for rtw_xmit.c
Date: Sun, 15 Mar 2026 17:08:40 -0500 [thread overview]
Message-ID: <DH3P5ZVHB08C.3ACSOF75W3CQ7@gmail.com> (raw)
In-Reply-To: <20260315210550.6058-1-marcosandrade95963@gmail.com>
On Sun Mar 15, 2026 at 4:05 PM CDT, Marcos Andrade wrote:
> This patch series cleans up rtw_xmit.c by replacing magic numbers with
> proper macros and updating the sleep API, as suggested by reviewers.
>
> Patch 1 replaces network magic numbers with EtherType macros.
> Patch 2 updates an msleep() call to the new fsleep() API.
>
> Changes in v4:
> - Fixed commit message line wrapping in patch 2/2 to comply with
> the 75-column limit, as suggested by Ethan Tidmore.
> Changes in v3:
> - Grouped the patches into a series because patch 2 depends on the
> include context of patch 1.
> Changes in v2:
> - Changed include from "" to <> for linux/if_ether.h.
> - Sorted includes alphabetically.
>
> Marcos Andrade (2):
> staging: rtl8723bs: Replace network magic numbers with EtherType
> macros
> staging: rtl8723bs: Replace msleep() with fsleep()
>
> drivers/staging/rtl8723bs/core/rtw_xmit.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
LGTM.
Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>
Thanks,
ET
prev parent reply other threads:[~2026-03-15 22:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-15 21:05 [PATCH v4 0/2] staging: rtl8723bs: Cleanups for rtw_xmit.c Marcos Andrade
2026-03-15 21:05 ` [PATCH v4 1/2] staging: rtl8723bs: Replace network magic numbers with EtherType macros Marcos Andrade
2026-03-15 21:05 ` [PATCH v4 2/2] staging: rtl8723bs: Replace msleep() with fsleep() Marcos Andrade
2026-03-15 22:08 ` Ethan Tidmore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DH3P5ZVHB08C.3ACSOF75W3CQ7@gmail.com \
--to=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=marcosandrade95963@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox