public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: "Ethan Tidmore" <ethantidmore06@gmail.com>
To: "Marcos Andrade" <marcosandrade95963@gmail.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: "Ethan Tidmore" <ethantidmore06@gmail.com>,
	<linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] staging: rtl8723bs: remove unused global efuse variables
Date: Mon, 16 Mar 2026 17:26:46 -0500	[thread overview]
Message-ID: <DH4K6E4V7UNG.13JD41LI1U7MO@gmail.com> (raw)
In-Reply-To: <20260316220435.2249-1-marcosandrade95963@gmail.com>

On Mon Mar 16, 2026 at 5:04 PM CDT, Marcos Andrade wrote:
> Remove several global efuse variables from rtw_efuse.c and their
> corresponding extern declarations in rtw_efuse.h.
>
> These variables (fakeEfuseBank, BTEfuseUsedBytes, etc.) are completely
> unused legacy code. The driver currently maintains the efuse state
> properly within the 'efuse_hal' structure, which is encapsulated
> inside 'hal_com_data'.
>
> The removal of this dead code cleans up the global namespace and
> resolves multiple checkpatch.pl warnings regarding CamelCase naming
> conventions. Verified by compilation that no functional code references
> these variables.
>
> Signed-off-by: Marcos Andrade <marcosandrade95963@gmail.com>
> Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>
> ---
> Changes in v2:
>  - Collected Reviewed-by tag from Ethan Tidmore.

You don't have to do this. Normally you only do this would a reivewer
gives you specifc instructions to do and then you can add their RB tag
with their approval.

Thanks,

ET

  reply	other threads:[~2026-03-16 22:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-16 22:04 [PATCH v2] staging: rtl8723bs: remove unused global efuse variables Marcos Andrade
2026-03-16 22:26 ` Ethan Tidmore [this message]
2026-03-16 22:27   ` Ethan Tidmore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DH4K6E4V7UNG.13JD41LI1U7MO@gmail.com \
    --to=ethantidmore06@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=marcosandrade95963@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox