[PATCH v2] staging: rtl8723bs: remove unused global efuse variables

[PATCH v2] staging: rtl8723bs: remove unused global efuse variables

[Marcos Andrade]

Remove several global efuse variables from rtw_efuse.c and their
corresponding extern declarations in rtw_efuse.h.

These variables (fakeEfuseBank, BTEfuseUsedBytes, etc.) are completely
unused legacy code. The driver currently maintains the efuse state
properly within the 'efuse_hal' structure, which is encapsulated
inside 'hal_com_data'.

The removal of this dead code cleans up the global namespace and
resolves multiple checkpatch.pl warnings regarding CamelCase naming
conventions. Verified by compilation that no functional code references
these variables.

Signed-off-by: Marcos Andrade <marcosandrade95963@gmail.com>
Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>
---
Changes in v2:
 - Collected Reviewed-by tag from Ethan Tidmore.

 drivers/staging/rtl8723bs/core/rtw_efuse.c    | 18 ------------------
 drivers/staging/rtl8723bs/include/rtw_efuse.h | 19 -------------------
 2 files changed, 37 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
index 98b15ca10..0e550c631 100644
--- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
+++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
@@ -8,24 +8,6 @@
 #include <hal_data.h>
 #include <linux/jiffies.h>
 
-
-/* Define global variables */
-u8 fakeEfuseBank;
-u32 fakeEfuseUsedBytes;
-u8 fakeEfuseContent[EFUSE_MAX_HW_SIZE] = {0};
-u8 fakeEfuseInitMap[EFUSE_MAX_MAP_LEN] = {0};
-u8 fakeEfuseModifiedMap[EFUSE_MAX_MAP_LEN] = {0};
-
-u32 BTEfuseUsedBytes;
-u8 BTEfuseContent[EFUSE_MAX_BT_BANK][EFUSE_MAX_HW_SIZE];
-u8 BTEfuseInitMap[EFUSE_BT_MAX_MAP_LEN] = {0};
-u8 BTEfuseModifiedMap[EFUSE_BT_MAX_MAP_LEN] = {0};
-
-u32 fakeBTEfuseUsedBytes;
-u8 fakeBTEfuseContent[EFUSE_MAX_BT_BANK][EFUSE_MAX_HW_SIZE];
-u8 fakeBTEfuseInitMap[EFUSE_BT_MAX_MAP_LEN] = {0};
-u8 fakeBTEfuseModifiedMap[EFUSE_BT_MAX_MAP_LEN] = {0};
-
 /*  11/16/2008 MH Add description. Get current efuse area enabled word!!. */
 u8
 Efuse_CalculateWordCnts(u8 word_en)
diff --git a/drivers/staging/rtl8723bs/include/rtw_efuse.h b/drivers/staging/rtl8723bs/include/rtw_efuse.h
index 936b204b8..191ffdf59 100644
--- a/drivers/staging/rtl8723bs/include/rtw_efuse.h
+++ b/drivers/staging/rtl8723bs/include/rtw_efuse.h
@@ -68,25 +68,6 @@ struct efuse_hal {
 	u8 fakeBTEfuseModifiedMap[EFUSE_BT_MAX_MAP_LEN];
 };
 
-
-/*------------------------Export global variable----------------------------*/
-extern u8 fakeEfuseBank;
-extern u32 fakeEfuseUsedBytes;
-extern u8 fakeEfuseContent[];
-extern u8 fakeEfuseInitMap[];
-extern u8 fakeEfuseModifiedMap[];
-
-extern u32 BTEfuseUsedBytes;
-extern u8 BTEfuseContent[EFUSE_MAX_BT_BANK][EFUSE_MAX_HW_SIZE];
-extern u8 BTEfuseInitMap[];
-extern u8 BTEfuseModifiedMap[];
-
-extern u32 fakeBTEfuseUsedBytes;
-extern u8 fakeBTEfuseContent[EFUSE_MAX_BT_BANK][EFUSE_MAX_HW_SIZE];
-extern u8 fakeBTEfuseInitMap[];
-extern u8 fakeBTEfuseModifiedMap[];
-/*------------------------Export global variable----------------------------*/
-
 u8 Efuse_CalculateWordCnts(u8 word_en);
 u8 efuse_OneByteRead(struct adapter *padapter, u16 addr, u8 *data);
 
-- 
2.53.0

Re: [PATCH v2] staging: rtl8723bs: remove unused global efuse variables

[Ethan Tidmore]

On Mon Mar 16, 2026 at 5:04 PM CDT, Marcos Andrade wrote:
> Remove several global efuse variables from rtw_efuse.c and their
> corresponding extern declarations in rtw_efuse.h.
>
> These variables (fakeEfuseBank, BTEfuseUsedBytes, etc.) are completely
> unused legacy code. The driver currently maintains the efuse state
> properly within the 'efuse_hal' structure, which is encapsulated
> inside 'hal_com_data'.
>
> The removal of this dead code cleans up the global namespace and
> resolves multiple checkpatch.pl warnings regarding CamelCase naming
> conventions. Verified by compilation that no functional code references
> these variables.
>
> Signed-off-by: Marcos Andrade <marcosandrade95963@gmail.com>
> Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>
> ---
> Changes in v2:
>  - Collected Reviewed-by tag from Ethan Tidmore.

You don't have to do this. Normally you only do this would a reivewer
gives you specifc instructions to do and then you can add their RB tag
with their approval.

Thanks,

ET

Re: [PATCH v2] staging: rtl8723bs: remove unused global efuse variables

[Ethan Tidmore]

On Mon Mar 16, 2026 at 5:26 PM CDT, Ethan Tidmore wrote:
> On Mon Mar 16, 2026 at 5:04 PM CDT, Marcos Andrade wrote:
>> Remove several global efuse variables from rtw_efuse.c and their
>> corresponding extern declarations in rtw_efuse.h.
>>
>> These variables (fakeEfuseBank, BTEfuseUsedBytes, etc.) are completely
>> unused legacy code. The driver currently maintains the efuse state
>> properly within the 'efuse_hal' structure, which is encapsulated
>> inside 'hal_com_data'.
>>
>> The removal of this dead code cleans up the global namespace and
>> resolves multiple checkpatch.pl warnings regarding CamelCase naming
>> conventions. Verified by compilation that no functional code references
>> these variables.
>>
>> Signed-off-by: Marcos Andrade <marcosandrade95963@gmail.com>
>> Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>
>> ---
>> Changes in v2:
>>  - Collected Reviewed-by tag from Ethan Tidmore.
>
> You don't have to do this. Normally you only do this would a reivewer
> gives you specifc instructions to do and then you can add their RB tag
> with their approval.
>
> Thanks,
>
> ET

With that said, you don't have to do anything now, just keep it in mind
for next time.

Thanks,

ET