From: "Ethan Tidmore" <ethantidmore06@gmail.com>
To: "MalavyaRaval" <malavyaraval@gmail.com>,
<gregkh@linuxfoundation.org>, <linux-staging@lists.linux.dev>,
<linux-kernel@vger.kernel.org>
Cc: <luka.gejak@gmail.com>
Subject: Re: [PATCH] staging: rtl8723bs: break long lines in rtw_sta_mgt.c
Date: Thu, 19 Mar 2026 13:58:10 -0500 [thread overview]
Message-ID: <DH6ZMB4R4HJN.3M9JIY3LOU8DT@gmail.com> (raw)
In-Reply-To: <20260319174229.62021-1-malavyaraval@gmail.com>
On Thu Mar 19, 2026 at 12:42 PM CDT, MalavyaRaval wrote:
> The original patch attempted to use the preferred sizeof(*ptr) style,
> but since the target variable is a u8 pointer, this caused a buffer
> overflow. Reverting to sizeof(struct sta_info) ensures the correct
> allocation size while satisfying the line-splitting requirement.
>
> Signed-off-by: MalavyaRaval <malavyaraval@gmail.com>
You need to put FirstName LastName <email>.
...
> - pstapriv->pallocated_stainfo_buf = vzalloc(sizeof(struct sta_info) * NUM_STA + 4);
> + pstapriv->pallocated_stainfo_buf = vzalloc(sizeof(struct sta_info) *
> + NUM_STA + 4);
This just makes the code harder to read.
Thanks,
ET
next prev parent reply other threads:[~2026-03-19 18:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 17:42 [PATCH] staging: rtl8723bs: break long lines in rtw_sta_mgt.c MalavyaRaval
2026-03-19 18:58 ` Ethan Tidmore [this message]
2026-03-19 18:59 ` Ethan Tidmore
-- strict thread matches above, loose matches on Subject: below --
2026-03-19 2:48 [PATCH] staging: rtl8723bs: Break " Malavya Raval
2026-03-19 8:39 ` Luka Gejak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DH6ZMB4R4HJN.3M9JIY3LOU8DT@gmail.com \
--to=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=luka.gejak@gmail.com \
--cc=malavyaraval@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox