From: "Ethan Tidmore" <ethantidmore06@gmail.com>
To: "MrXploisLite" <arokigaming@gmail.com>, <gregkh@linuxfoundation.org>
Cc: <linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: rtl8723bs: fix checkpatch style issues
Date: Thu, 26 Mar 2026 13:09:49 -0500 [thread overview]
Message-ID: <DHCWZ3XPKB4X.1QPLA1CDTWXOQ@gmail.com> (raw)
In-Reply-To: <20260325234511.24762-1-arokigaming@gmail.com>
On Wed Mar 25, 2026 at 6:45 PM CDT, MrXploisLite wrote:
> Fix minor style issues in hal_com.c reported by checkpatch:
> - Remove multiple blank lines
> - Remove blank line after open brace
> - Fix comparison style (constant on right side)
>
> No functional changes, only coding style fixes.
>
> Signed-off-by: MrXploisLite <arokigaming@gmail.com>
> ---
You need to use your real name when submitting patches. Also, don't use
the name of the tool in your subject, it should be something like
"Remove unneeded blank lines".
...
> - if (0xFF == hw_channel_plan)
> + if (hw_channel_plan == 0xFF)
> AutoLoadFail = true;
Please keep one logical change per patch. The removal of blank lines and
correcting comparison orientation are two different changes.
Use "$ ./scripts/checkpatch.pl --strict <patch>" too before sending
patches off, it helps catch a lot of easy mistakes.
Thanks,
ET
prev parent reply other threads:[~2026-03-26 18:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 23:45 [PATCH] staging: rtl8723bs: fix checkpatch style issues MrXploisLite
2026-03-26 18:09 ` Ethan Tidmore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DHCWZ3XPKB4X.1QPLA1CDTWXOQ@gmail.com \
--to=ethantidmore06@gmail.com \
--cc=arokigaming@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox