[PATCH] staging: rtl8723bs: fix checkpatch style issues

[PATCH] staging: rtl8723bs: fix checkpatch style issues

[MrXploisLite]

Fix minor style issues in hal_com.c reported by checkpatch:
- Remove multiple blank lines
- Remove blank line after open brace
- Fix comparison style (constant on right side)

No functional changes, only coding style fixes.

Signed-off-by: MrXploisLite <arokigaming@gmail.com>
---
 drivers/staging/rtl8723bs/hal/hal_com.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8723bs/hal/hal_com.c
index 50370b14c..1298ab2e5 100644
--- a/drivers/staging/rtl8723bs/hal/hal_com.c
+++ b/drivers/staging/rtl8723bs/hal/hal_com.c
@@ -30,7 +30,6 @@ void rtw_hal_data_deinit(struct adapter *padapter)
 	}
 }
 
-
 void dump_chip_info(struct hal_version	ChipVersion)
 {
 	char buf[128];
@@ -71,7 +70,6 @@ void dump_chip_info(struct hal_version	ChipVersion)
 	cnt += scnprintf(buf + cnt, sizeof(buf) - cnt, "RomVer(%d)\n", ChipVersion.ROMVer);
 }
 
-
 #define	EEPROM_CHANNEL_PLAN_BY_HW_MASK	0x80
 
 /*
@@ -107,7 +105,7 @@ u8 hal_com_config_channel_plan(
 	pHalData->bDisableSWChannelPlan = false;
 	chnlPlan = def_channel_plan;
 
-	if (0xFF == hw_channel_plan)
+	if (hw_channel_plan == 0xFF)
 		AutoLoadFail = true;
 
 	if (!AutoLoadFail) {
@@ -294,7 +292,6 @@ void HalSetBrateCfg(struct adapter *Adapter, u8 *mBratesOS, u16 *pBrateCfg)
 	u8 i, is_brate, brate;
 
 	for (i = 0; i < NDIS_802_11_LENGTH_RATES_EX; i++) {
-
 		is_brate = mBratesOS[i] & IEEE80211_BASIC_RATE_MASK;
 		brate = mBratesOS[i] & 0x7f;
 
-- 
2.53.0

Re: [PATCH] staging: rtl8723bs: fix checkpatch style issues

[Ethan Tidmore]

On Wed Mar 25, 2026 at 6:45 PM CDT, MrXploisLite wrote:
> Fix minor style issues in hal_com.c reported by checkpatch:
> - Remove multiple blank lines
> - Remove blank line after open brace
> - Fix comparison style (constant on right side)
>
> No functional changes, only coding style fixes.
>
> Signed-off-by: MrXploisLite <arokigaming@gmail.com>
> ---

You need to use your real name when submitting patches. Also, don't use
the name of the tool in your subject, it should be something like
"Remove unneeded blank lines".

...

> -	if (0xFF == hw_channel_plan)
> +	if (hw_channel_plan == 0xFF)
>  		AutoLoadFail = true;

Please keep one logical change per patch. The removal of blank lines and
correcting comparison orientation are two different changes.

Use "$ ./scripts/checkpatch.pl --strict <patch>" too before sending
patches off, it helps catch a lot of easy mistakes.

Thanks,

ET