* [PATCH v2 0/2] staging: rtl8723bs: cleanup rtw_io.c
@ 2026-04-02 16:23 Nikolay Kulikov
2026-04-02 16:23 ` [PATCH v2 1/2] staging: rtl8723bs: remove dead code in rtw_io.c Nikolay Kulikov
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Nikolay Kulikov @ 2026-04-02 16:23 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-staging, linux-kernel, Nikolay Kulikov
This series removes the dead code and fixes separators in core/rtw_io.c
Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
---
Changes in v2:
- Add the prefix "staging: rtl8723bs:" to the cover-letter heading
- Link to v1: https://lore.kernel.org/r/20260402-cleanup_rtw_io-v1-0-874b9747de6b@gmail.com
---
Nikolay Kulikov (2):
staging: rtl8723bs: remove dead code in rtw_io.c
staging: rtl8723bs: replace tabs used as separators with spaces
drivers/staging/rtl8723bs/core/rtw_io.c | 20 +++++++-------------
1 file changed, 7 insertions(+), 13 deletions(-)
---
base-commit: e87946666e47d4b6f615e9ba0075375493194810
change-id: 20260402-cleanup_rtw_io-ce1725cf50b8
Best regards,
--
Nikolay Kulikov <nikolayof23@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2 1/2] staging: rtl8723bs: remove dead code in rtw_io.c
2026-04-02 16:23 [PATCH v2 0/2] staging: rtl8723bs: cleanup rtw_io.c Nikolay Kulikov
@ 2026-04-02 16:23 ` Nikolay Kulikov
2026-04-02 16:23 ` [PATCH v2 2/2] staging: rtl8723bs: replace tabs used as separators with spaces Nikolay Kulikov
2026-04-02 18:17 ` [PATCH v2 0/2] staging: rtl8723bs: cleanup rtw_io.c Ethan Tidmore
2 siblings, 0 replies; 4+ messages in thread
From: Nikolay Kulikov @ 2026-04-02 16:23 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-staging, linux-kernel, Nikolay Kulikov
Remove the commented variable declarations as they are not used
anywhere.
Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_io.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_io.c b/drivers/staging/rtl8723bs/core/rtw_io.c
index 53ba99e1de00..ff16027ee129 100644
--- a/drivers/staging/rtl8723bs/core/rtw_io.c
+++ b/drivers/staging/rtl8723bs/core/rtw_io.c
@@ -27,7 +27,6 @@
u8 rtw_read8(struct adapter *adapter, u32 addr)
{
- /* struct io_queue *pio_queue = (struct io_queue *)adapter->pio_queue; */
struct io_priv *pio_priv = &adapter->iopriv;
struct intf_hdl *pintfhdl = &pio_priv->intf;
u8 (*_read8)(struct intf_hdl *pintfhdl, u32 addr);
@@ -39,7 +38,6 @@ u8 rtw_read8(struct adapter *adapter, u32 addr)
u16 rtw_read16(struct adapter *adapter, u32 addr)
{
- /* struct io_queue *pio_queue = (struct io_queue *)adapter->pio_queue; */
struct io_priv *pio_priv = &adapter->iopriv;
struct intf_hdl *pintfhdl = &pio_priv->intf;
u16 (*_read16)(struct intf_hdl *pintfhdl, u32 addr);
@@ -51,7 +49,6 @@ u16 rtw_read16(struct adapter *adapter, u32 addr)
u32 rtw_read32(struct adapter *adapter, u32 addr)
{
- /* struct io_queue *pio_queue = (struct io_queue *)adapter->pio_queue; */
struct io_priv *pio_priv = &adapter->iopriv;
struct intf_hdl *pintfhdl = &pio_priv->intf;
u32 (*_read32)(struct intf_hdl *pintfhdl, u32 addr);
@@ -63,7 +60,6 @@ u32 rtw_read32(struct adapter *adapter, u32 addr)
int rtw_write8(struct adapter *adapter, u32 addr, u8 val)
{
- /* struct io_queue *pio_queue = (struct io_queue *)adapter->pio_queue; */
struct io_priv *pio_priv = &adapter->iopriv;
struct intf_hdl *pintfhdl = &pio_priv->intf;
int (*_write8)(struct intf_hdl *pintfhdl, u32 addr, u8 val);
@@ -78,7 +74,6 @@ int rtw_write8(struct adapter *adapter, u32 addr, u8 val)
int rtw_write16(struct adapter *adapter, u32 addr, u16 val)
{
- /* struct io_queue *pio_queue = (struct io_queue *)adapter->pio_queue; */
struct io_priv *pio_priv = &adapter->iopriv;
struct intf_hdl *pintfhdl = &pio_priv->intf;
int (*_write16)(struct intf_hdl *pintfhdl, u32 addr, u16 val);
@@ -92,7 +87,6 @@ int rtw_write16(struct adapter *adapter, u32 addr, u16 val)
int rtw_write32(struct adapter *adapter, u32 addr, u32 val)
{
- /* struct io_queue *pio_queue = (struct io_queue *)adapter->pio_queue; */
struct io_priv *pio_priv = &adapter->iopriv;
struct intf_hdl *pintfhdl = &pio_priv->intf;
int (*_write32)(struct intf_hdl *pintfhdl, u32 addr, u32 val);
--
2.53.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2 2/2] staging: rtl8723bs: replace tabs used as separators with spaces
2026-04-02 16:23 [PATCH v2 0/2] staging: rtl8723bs: cleanup rtw_io.c Nikolay Kulikov
2026-04-02 16:23 ` [PATCH v2 1/2] staging: rtl8723bs: remove dead code in rtw_io.c Nikolay Kulikov
@ 2026-04-02 16:23 ` Nikolay Kulikov
2026-04-02 18:17 ` [PATCH v2 0/2] staging: rtl8723bs: cleanup rtw_io.c Ethan Tidmore
2 siblings, 0 replies; 4+ messages in thread
From: Nikolay Kulikov @ 2026-04-02 16:23 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-staging, linux-kernel, Nikolay Kulikov
Replace tabs in variable initialization lines with spaces to make code
more consistent.
Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_io.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_io.c b/drivers/staging/rtl8723bs/core/rtw_io.c
index ff16027ee129..c793ae7ea5c4 100644
--- a/drivers/staging/rtl8723bs/core/rtw_io.c
+++ b/drivers/staging/rtl8723bs/core/rtw_io.c
@@ -28,7 +28,7 @@
u8 rtw_read8(struct adapter *adapter, u32 addr)
{
struct io_priv *pio_priv = &adapter->iopriv;
- struct intf_hdl *pintfhdl = &pio_priv->intf;
+ struct intf_hdl *pintfhdl = &pio_priv->intf;
u8 (*_read8)(struct intf_hdl *pintfhdl, u32 addr);
_read8 = pintfhdl->io_ops._read8;
@@ -39,7 +39,7 @@ u8 rtw_read8(struct adapter *adapter, u32 addr)
u16 rtw_read16(struct adapter *adapter, u32 addr)
{
struct io_priv *pio_priv = &adapter->iopriv;
- struct intf_hdl *pintfhdl = &pio_priv->intf;
+ struct intf_hdl *pintfhdl = &pio_priv->intf;
u16 (*_read16)(struct intf_hdl *pintfhdl, u32 addr);
_read16 = pintfhdl->io_ops._read16;
@@ -50,7 +50,7 @@ u16 rtw_read16(struct adapter *adapter, u32 addr)
u32 rtw_read32(struct adapter *adapter, u32 addr)
{
struct io_priv *pio_priv = &adapter->iopriv;
- struct intf_hdl *pintfhdl = &pio_priv->intf;
+ struct intf_hdl *pintfhdl = &pio_priv->intf;
u32 (*_read32)(struct intf_hdl *pintfhdl, u32 addr);
_read32 = pintfhdl->io_ops._read32;
@@ -61,7 +61,7 @@ u32 rtw_read32(struct adapter *adapter, u32 addr)
int rtw_write8(struct adapter *adapter, u32 addr, u8 val)
{
struct io_priv *pio_priv = &adapter->iopriv;
- struct intf_hdl *pintfhdl = &pio_priv->intf;
+ struct intf_hdl *pintfhdl = &pio_priv->intf;
int (*_write8)(struct intf_hdl *pintfhdl, u32 addr, u8 val);
int ret;
@@ -75,7 +75,7 @@ int rtw_write8(struct adapter *adapter, u32 addr, u8 val)
int rtw_write16(struct adapter *adapter, u32 addr, u16 val)
{
struct io_priv *pio_priv = &adapter->iopriv;
- struct intf_hdl *pintfhdl = &pio_priv->intf;
+ struct intf_hdl *pintfhdl = &pio_priv->intf;
int (*_write16)(struct intf_hdl *pintfhdl, u32 addr, u16 val);
int ret;
@@ -88,7 +88,7 @@ int rtw_write16(struct adapter *adapter, u32 addr, u16 val)
int rtw_write32(struct adapter *adapter, u32 addr, u32 val)
{
struct io_priv *pio_priv = &adapter->iopriv;
- struct intf_hdl *pintfhdl = &pio_priv->intf;
+ struct intf_hdl *pintfhdl = &pio_priv->intf;
int (*_write32)(struct intf_hdl *pintfhdl, u32 addr, u32 val);
int ret;
@@ -103,7 +103,7 @@ u32 rtw_write_port(struct adapter *adapter, u32 addr, u32 cnt, u8 *pmem)
{
u32 (*_write_port)(struct intf_hdl *pintfhdl, u32 addr, u32 cnt, u8 *pmem);
struct io_priv *pio_priv = &adapter->iopriv;
- struct intf_hdl *pintfhdl = &pio_priv->intf;
+ struct intf_hdl *pintfhdl = &pio_priv->intf;
_write_port = pintfhdl->io_ops._write_port;
--
2.53.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 0/2] staging: rtl8723bs: cleanup rtw_io.c
2026-04-02 16:23 [PATCH v2 0/2] staging: rtl8723bs: cleanup rtw_io.c Nikolay Kulikov
2026-04-02 16:23 ` [PATCH v2 1/2] staging: rtl8723bs: remove dead code in rtw_io.c Nikolay Kulikov
2026-04-02 16:23 ` [PATCH v2 2/2] staging: rtl8723bs: replace tabs used as separators with spaces Nikolay Kulikov
@ 2026-04-02 18:17 ` Ethan Tidmore
2 siblings, 0 replies; 4+ messages in thread
From: Ethan Tidmore @ 2026-04-02 18:17 UTC (permalink / raw)
To: Nikolay Kulikov, Greg Kroah-Hartman; +Cc: linux-staging, linux-kernel
On Thu Apr 2, 2026 at 11:23 AM CDT, Nikolay Kulikov wrote:
> This series removes the dead code and fixes separators in core/rtw_io.c
>
> Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
> ---
LGTM.
Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>
Thanks,
ET
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-04-02 18:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-02 16:23 [PATCH v2 0/2] staging: rtl8723bs: cleanup rtw_io.c Nikolay Kulikov
2026-04-02 16:23 ` [PATCH v2 1/2] staging: rtl8723bs: remove dead code in rtw_io.c Nikolay Kulikov
2026-04-02 16:23 ` [PATCH v2 2/2] staging: rtl8723bs: replace tabs used as separators with spaces Nikolay Kulikov
2026-04-02 18:17 ` [PATCH v2 0/2] staging: rtl8723bs: cleanup rtw_io.c Ethan Tidmore
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox