Re: [PATCH v3 0/6] staging: rtl8723bs: cleanup code and style

["Ethan Tidmore" <ethantidmore06@gmail.com>]

On Fri Apr 3, 2026 at 1:40 AM CDT, Greg Kroah-Hartman wrote:
> On Thu, Apr 02, 2026 at 04:43:06PM -0500, Ethan Tidmore wrote:
>> On Thu Apr 2, 2026 at 10:04 AM CDT, Andrei Khomenkov wrote:
>> > This series of patches cleans up the rtl8723bs driver code to improve
>> > readability and better aligns with the Linux kernel coding style.
>> > The first three patches simplify boolean comparisons, and the next
>> > three perform general code cleanup.
>> >
>> > I figured I needed to split the changes into directories, so I did
>> > that. I also think each commit should do only one thing, so in the
>> > last three commits, I fixed the style that wasn't related to the
>> > logical changes with ' == true' and ' == false' that were in the first
>> > three commits. However, if both the logic and the style need to be
>> > fixed in the same commit, let me know, and I'll make v4.
>> >
>> > Link: https://lore.kernel.org/linux-staging/20260330184640.17795-1-khomenkov@mailbox.org/
>> >
>> > v3:
>> >  - Split the commits into even more commits, each commit
>> >    affecting one driver directory.
>> >
>> > v2:
>> >  - Split the single patch into a two-patch series to separate 
>> >    logical changes, as suggested by Luka Gejak.
>> >  - Cleaned up additional boolean comparisons found using 'git grep'.
>> >
>> > Andrei Khomenkov (6):
>> >   staging: rtl8723bs: core: simplify boolean comparisons
>> >   staging: rtl8723bs: hal: simplify boolean comparisons
>> >   staging: rtl8723bs: os_dep: simplify boolean comparisons
>> >   staging: rtl8723bs: core: style cleanup
>> >   staging: rtl8723bs: hal: style cleanup
>> >   staging: rtl8723bs: os_dep: style cleanup
>> 
>> Instead of "staging: rtl8723bs: os_dep: style cleanup" do "staging:
>> rtl8723bs: style cleanup in os_dep/". For this driver the standard
>> prefix is "staging: rtl8723bs:".
>
> Either is really fine, we are not _that_ picky :)

I feel like you've corrected me on this before, this time I thought it
was a little different, but I see what you're saying.

I'll try not to be as pedantic with prefixes anymore :)

Thanks,

ET