From: "Ethan Tidmore" <ethantidmore06@gmail.com>
To: "Andrei Khomenkov" <khomenkov@mailbox.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: "Ethan Tidmore" <ethantidmore06@gmail.com>,
"Dan Carpenter" <error27@gmail.com>,
<linux-staging@lists.linux.dev>
Subject: Re: [PATCH v4 1/3] staging: rtl8723bs: core: cleanup booleans and style
Date: Mon, 06 Apr 2026 15:51:25 -0500 [thread overview]
Message-ID: <DHMDAU082PV0.3UBKYLS6Y2K8P@gmail.com> (raw)
In-Reply-To: <20260405160135.22291-2-khomenkov@mailbox.org>
On Sun Apr 5, 2026 at 11:01 AM CDT, Andrei Khomenkov wrote:
> Simplify boolean comparisons by removing redundant ' == true',
> ' != true', and ' == false'. Remove redundant parentheses, add
> spaces around bitwise operators, and wrap logical operators to
> the previous line in if-statements to improve readability and
> follow the kernel coding style.
These are three different types of changes that should be their own
patches. Please keep one logical change per patch. The rule of thumb is
if you have to use 'and' in your patch notes you probably need to split
it up.
Thanks,
ET
next prev parent reply other threads:[~2026-04-06 20:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-05 16:01 [PATCH v4 0/3] staging: rtl8723bs: cleanup booleans and style Andrei Khomenkov
2026-04-05 16:01 ` [PATCH v4 1/3] staging: rtl8723bs: core: " Andrei Khomenkov
2026-04-06 20:51 ` Ethan Tidmore [this message]
2026-04-05 16:01 ` [PATCH v4 2/3] staging: rtl8723bs: hal: " Andrei Khomenkov
2026-04-05 16:01 ` [PATCH v4 3/3] staging: rtl8723bs: os_dep: " Andrei Khomenkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DHMDAU082PV0.3UBKYLS6Y2K8P@gmail.com \
--to=ethantidmore06@gmail.com \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=khomenkov@mailbox.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox