* [PATCH] staging: rtl8723bs: remove redundant returns in rtw_mlme_ext.c
@ 2026-04-04 11:48 Hungyu Lin
2026-04-08 15:35 ` Luka Gejak
0 siblings, 1 reply; 2+ messages in thread
From: Hungyu Lin @ 2026-04-04 11:48 UTC (permalink / raw)
To: gregkh; +Cc: dan.carpenter, linux-staging, linux-kernel, Hungyu Lin
Remove redundant return statements at the end of void functions
in rtw_mlme_ext.c.
No functional change.
Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 15 ---------------
1 file changed, 15 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
index dad1d95bc325..335f5b2c96f0 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
@@ -2417,9 +2417,6 @@ void issue_probersp(struct adapter *padapter, unsigned char *da, u8 is_valid_p2p
dump_mgntframe(padapter, pmgntframe);
-
- return;
-
}
static int _issue_probereq(struct adapter *padapter,
@@ -3877,9 +3874,6 @@ void site_survey(struct adapter *padapter)
issue_action_BSSCoexistPacket(padapter);
}
}
-
- return;
-
}
/* collect bss info from Beacon and Probe request/response frames. */
@@ -4414,9 +4408,6 @@ void report_survey_event(struct adapter *padapter, union recv_frame *precv_frame
rtw_enqueue_cmd(pcmdpriv, pcmd_obj);
pmlmeext->sitesurvey_res.bss_cnt++;
-
- return;
-
}
void report_surveydone_event(struct adapter *padapter)
@@ -4458,9 +4449,6 @@ void report_surveydone_event(struct adapter *padapter)
psurveydone_evt->bss_cnt = pmlmeext->sitesurvey_res.bss_cnt;
rtw_enqueue_cmd(pcmdpriv, pcmd_obj);
-
- return;
-
}
void report_join_res(struct adapter *padapter, int res)
@@ -4549,9 +4537,6 @@ void report_wmm_edca_update(struct adapter *padapter)
pwmm_event->wmm = 0;
rtw_enqueue_cmd(pcmdpriv, pcmd_obj);
-
- return;
-
}
void report_del_sta_event(struct adapter *padapter, unsigned char *MacAddr, unsigned short reason)
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rtl8723bs: remove redundant returns in rtw_mlme_ext.c
2026-04-04 11:48 [PATCH] staging: rtl8723bs: remove redundant returns in rtw_mlme_ext.c Hungyu Lin
@ 2026-04-08 15:35 ` Luka Gejak
0 siblings, 0 replies; 2+ messages in thread
From: Luka Gejak @ 2026-04-08 15:35 UTC (permalink / raw)
To: Hungyu Lin, gregkh; +Cc: dan.carpenter, linux-staging, linux-kernel
On Sat Apr 4, 2026 at 1:48 PM CEST, Hungyu Lin wrote:
> Remove redundant return statements at the end of void functions
> in rtw_mlme_ext.c.
>
> No functional change.
>
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 15 ---------------
> 1 file changed, 15 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> index dad1d95bc325..335f5b2c96f0 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> @@ -2417,9 +2417,6 @@ void issue_probersp(struct adapter *padapter, unsigned char *da, u8 is_valid_p2p
>
>
> dump_mgntframe(padapter, pmgntframe);
> -
> - return;
> -
> }
>
> static int _issue_probereq(struct adapter *padapter,
> @@ -3877,9 +3874,6 @@ void site_survey(struct adapter *padapter)
> issue_action_BSSCoexistPacket(padapter);
> }
> }
> -
> - return;
> -
> }
>
> /* collect bss info from Beacon and Probe request/response frames. */
> @@ -4414,9 +4408,6 @@ void report_survey_event(struct adapter *padapter, union recv_frame *precv_frame
> rtw_enqueue_cmd(pcmdpriv, pcmd_obj);
>
> pmlmeext->sitesurvey_res.bss_cnt++;
> -
> - return;
> -
> }
>
> void report_surveydone_event(struct adapter *padapter)
> @@ -4458,9 +4449,6 @@ void report_surveydone_event(struct adapter *padapter)
> psurveydone_evt->bss_cnt = pmlmeext->sitesurvey_res.bss_cnt;
>
> rtw_enqueue_cmd(pcmdpriv, pcmd_obj);
> -
> - return;
> -
> }
>
> void report_join_res(struct adapter *padapter, int res)
> @@ -4549,9 +4537,6 @@ void report_wmm_edca_update(struct adapter *padapter)
> pwmm_event->wmm = 0;
>
> rtw_enqueue_cmd(pcmdpriv, pcmd_obj);
> -
> - return;
> -
> }
>
> void report_del_sta_event(struct adapter *padapter, unsigned char *MacAddr, unsigned short reason)
LGTM
Reviewed-by: Luka Gejak <luka.gejak@linux.dev>
Best regards,
Luka Gejak
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-04-08 15:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-04 11:48 [PATCH] staging: rtl8723bs: remove redundant returns in rtw_mlme_ext.c Hungyu Lin
2026-04-08 15:35 ` Luka Gejak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox