* [PATCH] staging: rtl8723bs: remove redundant return in report_join_res()
@ 2026-04-04 11:03 Hungyu Lin
2026-04-04 23:21 ` Ethan Tidmore
2026-04-08 15:56 ` Luka Gejak
0 siblings, 2 replies; 3+ messages in thread
From: Hungyu Lin @ 2026-04-04 11:03 UTC (permalink / raw)
To: gregkh; +Cc: dan.carpenter, linux-staging, linux-kernel, Hungyu Lin
The return statement at the end of this void function is redundant
and can be removed.
No functional change.
Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
index b1f20aa81efb..dad1d95bc325 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
@@ -4508,9 +4508,6 @@ void report_join_res(struct adapter *padapter, int res)
rtw_enqueue_cmd(pcmdpriv, pcmd_obj);
-
- return;
-
}
void report_wmm_edca_update(struct adapter *padapter)
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: rtl8723bs: remove redundant return in report_join_res()
2026-04-04 11:03 [PATCH] staging: rtl8723bs: remove redundant return in report_join_res() Hungyu Lin
@ 2026-04-04 23:21 ` Ethan Tidmore
2026-04-08 15:56 ` Luka Gejak
1 sibling, 0 replies; 3+ messages in thread
From: Ethan Tidmore @ 2026-04-04 23:21 UTC (permalink / raw)
To: Hungyu Lin, gregkh; +Cc: dan.carpenter, linux-staging, linux-kernel
On Sat Apr 4, 2026 at 6:03 AM CDT, Hungyu Lin wrote:
> The return statement at the end of this void function is redundant
> and can be removed.
>
> No functional change.
>
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
> ---
LGTM.
Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>
Thanks,
ET
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: rtl8723bs: remove redundant return in report_join_res()
2026-04-04 11:03 [PATCH] staging: rtl8723bs: remove redundant return in report_join_res() Hungyu Lin
2026-04-04 23:21 ` Ethan Tidmore
@ 2026-04-08 15:56 ` Luka Gejak
1 sibling, 0 replies; 3+ messages in thread
From: Luka Gejak @ 2026-04-08 15:56 UTC (permalink / raw)
To: Hungyu Lin, gregkh; +Cc: dan.carpenter, linux-staging, linux-kernel
On Sat Apr 4, 2026 at 1:03 PM CEST, Hungyu Lin wrote:
> The return statement at the end of this void function is redundant
> and can be removed.
>
> No functional change.
>
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> index b1f20aa81efb..dad1d95bc325 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> @@ -4508,9 +4508,6 @@ void report_join_res(struct adapter *padapter, int res)
>
>
> rtw_enqueue_cmd(pcmdpriv, pcmd_obj);
> -
> - return;
> -
> }
>
> void report_wmm_edca_update(struct adapter *padapter)
LGTM
Reviewed-by: Luka Gejak <luka.gejak@linux.dev>
Best regards,
Luka Gejak
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-04-08 15:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-04 11:03 [PATCH] staging: rtl8723bs: remove redundant return in report_join_res() Hungyu Lin
2026-04-04 23:21 ` Ethan Tidmore
2026-04-08 15:56 ` Luka Gejak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox