From: "Luka Gejak" <luka.gejak@linux.dev>
To: "Prithvi Tambewagh" <activprithvi@gmail.com>,
<gregkh@linuxfoundation.org>, <abrahamadekunle50@gmail.com>,
<b9788213@gmail.com>, <straube.linux@gmail.com>,
<tmimiharoen@gmail.com>, <filippo.muschera@gmail.com>,
<ethantidmore06@gmail.com>, <andriy.shevchenko@linux.intel.com>,
<rayfraytech@gmail.com>, <david@cardinalsystem.net>,
<weibu@redadmin.org>, <dharanitharan725@gmail.com>,
<ignacio.pena87@gmail.com>, <dan.carpenter@linaro.org>,
<karanja99erick@gmail.com>, <luka.gejak@linux.dev>,
<khushalchitturi@gmail.com>, <suunj1331@gmail.com>,
<s9430939@naver.com>, <nikolayof23@gmail.com>,
<bryant.boatright@proton.me>, <ysinghcin@gmail.com>
Cc: <linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
<linux-kernel-mentees@lists.linux.dev>,
<skhan@linuxfoundation.org>, <david.hunter.linux@gmail.com>,
<khalid@kernel.org>
Subject: Re: [PATCH v4 2/5] staging: rtl8723bs: remove empty if statement block
Date: Thu, 09 Apr 2026 16:10:18 +0200 [thread overview]
Message-ID: <DHOONCA4SEWT.1C6W6Z75S2358@linux.dev> (raw)
In-Reply-To: <20260409135026.137904-3-activprithvi@gmail.com>
On Thu Apr 9, 2026 at 3:50 PM CEST, Prithvi Tambewagh wrote:
> Remove empty if statement block for cleaning up code.
>
> Signed-off-by: Prithvi Tambewagh <activprithvi@gmail.com>
> ---
> drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
> index 0780847e287d..6ab65e9e8bee 100644
> --- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
> +++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
> @@ -1415,9 +1415,6 @@ static void phy_IQCalibrate_8723B(
> }
> }
>
> - if (0x00 == PathAOK) {
> - }
> -
> /* path B IQK */
> if (is2T) {
>
LGTM.
Reviewed-by: Luka Gejak <luka.gejak@linux.dev>
Best regards,
Luka Gejak
next prev parent reply other threads:[~2026-04-09 14:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 13:50 [PATCH v4 0/5] staging: rtl8723bs: Code cleanup in drivers/staging/rtl8723bs Prithvi Tambewagh
2026-04-09 13:50 ` [PATCH v4 1/5] staging: rtl8723bs: move constant to right side of test in comparison Prithvi Tambewagh
2026-04-09 14:10 ` Luka Gejak
2026-04-09 13:50 ` [PATCH v4 2/5] staging: rtl8723bs: remove empty if statement block Prithvi Tambewagh
2026-04-09 14:10 ` Luka Gejak [this message]
2026-04-09 13:50 ` [PATCH v4 3/5] staging: rtl8723bs: simplify boolean return in IsFrameTypeCtrl() Prithvi Tambewagh
2026-04-09 14:10 ` Luka Gejak
2026-04-09 13:50 ` [PATCH v4 4/5] staging: rtl8723bs: use read_poll_timeout_atomic in _is_fw_read_cmd_down Prithvi Tambewagh
2026-04-09 14:10 ` Luka Gejak
2026-04-09 13:50 ` [PATCH v4 5/5] staging: rtl8723bs: remove duplicate rate checks in PHY_GetTxPowerIndexBase() Prithvi Tambewagh
2026-04-09 14:14 ` Luka Gejak
2026-04-09 14:18 ` [PATCH v4 0/5] staging: rtl8723bs: Code cleanup in drivers/staging/rtl8723bs Luka Gejak
2026-04-09 14:50 ` Prithvi
2026-04-09 14:57 ` Luka Gejak
2026-04-09 15:30 ` Prithvi
2026-04-09 15:32 ` Luka Gejak
2026-04-09 15:42 ` Luka Gejak
2026-04-09 15:02 ` Greg KH
2026-04-09 15:39 ` Prithvi
2026-04-09 15:44 ` Luka Gejak
2026-04-09 15:55 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DHOONCA4SEWT.1C6W6Z75S2358@linux.dev \
--to=luka.gejak@linux.dev \
--cc=abrahamadekunle50@gmail.com \
--cc=activprithvi@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=b9788213@gmail.com \
--cc=bryant.boatright@proton.me \
--cc=dan.carpenter@linaro.org \
--cc=david.hunter.linux@gmail.com \
--cc=david@cardinalsystem.net \
--cc=dharanitharan725@gmail.com \
--cc=ethantidmore06@gmail.com \
--cc=filippo.muschera@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ignacio.pena87@gmail.com \
--cc=karanja99erick@gmail.com \
--cc=khalid@kernel.org \
--cc=khushalchitturi@gmail.com \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nikolayof23@gmail.com \
--cc=rayfraytech@gmail.com \
--cc=s9430939@naver.com \
--cc=skhan@linuxfoundation.org \
--cc=straube.linux@gmail.com \
--cc=suunj1331@gmail.com \
--cc=tmimiharoen@gmail.com \
--cc=weibu@redadmin.org \
--cc=ysinghcin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox