From: "Luka Gejak" <luka.gejak@linux.dev>
To: "Nguyen Duc Thinh" <ducthinh100812@gmail.com>,
<gregkh@linuxfoundation.org>
Cc: <linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/1] staging: rtl8723bs: verify boolean and logics and rename dot11AuthAlgrthm
Date: Sat, 11 Apr 2026 17:40:39 +0200 [thread overview]
Message-ID: <DHQFTM1FG7B7.18GOSSZDHD5JM@linux.dev> (raw)
In-Reply-To: <20260411035303.859-1-ducthinh100812@gmail.com>
On Sat Apr 11, 2026 at 5:53 AM CEST, Nguyen Duc Thinh wrote:
> This series cleans up the rtl8723bs driver by renaming the CamelCase variable dot11AuthAlgrthm to dot11_auth_algrthm and refactoring boolean comparisons to follow Linux coding standards. Both changes were verified by building individual object files and running checkpatch.pl.
Please wrap all text to 72 characters. Also you don't need cover letter
for 1 patch, so unless you properly split this into 2 patches you don't
need cover letter, but more on that in inline review of the patch.
>
> Nguyen Duc Thinh (1):
> staging: rtl8723bs: verify boolean and logics and rename
> dot11AuthAlgrthm
>
> drivers/staging/rtl8723bs/core/rtw_ap.c | 28 ++++----
> drivers/staging/rtl8723bs/core/rtw_btcoex.c | 2 +-
> .../staging/rtl8723bs/core/rtw_ieee80211.c | 2 +-
> .../staging/rtl8723bs/core/rtw_ioctl_set.c | 40 +++++------
> drivers/staging/rtl8723bs/core/rtw_mlme.c | 16 ++---
> drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 22 +++---
> drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 2 +-
> drivers/staging/rtl8723bs/core/rtw_recv.c | 70 +++++++++----------
> drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 2 +-
> .../staging/rtl8723bs/core/rtw_wlan_util.c | 8 +--
> drivers/staging/rtl8723bs/core/rtw_xmit.c | 36 +++++-----
> drivers/staging/rtl8723bs/hal/hal_com.c | 2 +-
> drivers/staging/rtl8723bs/include/rtw_mlme.h | 12 ++--
> .../staging/rtl8723bs/include/rtw_security.h | 14 ++--
> .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 32 ++++-----
> drivers/staging/rtl8723bs/os_dep/os_intfs.c | 2 +-
> 16 files changed, 145 insertions(+), 145 deletions(-)
prev parent reply other threads:[~2026-04-11 15:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-11 3:53 [PATCH 0/1] staging: rtl8723bs: verify boolean and logics and rename dot11AuthAlgrthm Nguyen Duc Thinh
2026-04-11 3:53 ` [PATCH] " Nguyen Duc Thinh
2026-04-11 16:48 ` Luka Gejak
2026-04-11 15:40 ` Luka Gejak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DHQFTM1FG7B7.18GOSSZDHD5JM@linux.dev \
--to=luka.gejak@linux.dev \
--cc=ducthinh100812@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox