Re: [PATCH 2/9] staging: rtl8723bs: fix space-before-tab whitespace

Andy Shevchenko
2026-04-14T11:48:13Z

On Tue, Apr 14, 2026 at 12:58:26PM +0300, Marc Finkelbaum wrote:
> Replace tab characters with a single space in macro definitions
> (EEPROM_CHANNEL_PLAN_BY_HW_MASK, REG_RF_BB_GAIN_OFFSET), the
> dump_chip_info parameter list, the pHalData pointer declaration in
> SetHalODMVar, and the BK/BE/VI/VO tabular comments inside
> _TwoOutPipeMapping and _ThreeOutPipeMapping.
>
> No functional change.

...

> -#define EEPROM_CHANNEL_PLAN_BY_HW_MASK 0x80
> +#define EEPROM_CHANNEL_PLAN_BY_HW_MASK 0x80

Please, leave tab indentation of the value (between K and 0).

...

> -#define REG_RF_BB_GAIN_OFFSET 0x7f
> +#define REG_RF_BB_GAIN_OFFSET 0x7f

Ditto.

> //#define RF_GAIN_OFFSET_MASK 0xfffff

This (and these in general) has to be fixed accordingly as it's clearly not an
example of the code in the comment, but a real code that got commented out for
some reason. For the latter the style should be adjusted accordingly.

--
With Best Regards,
Andy Shevchenko