Re: [PATCH 3/9] staging: rtl8723bs: fix block comment alignment

Andy Shevchenko
2026-04-14T11:51:26Z

On Tue, Apr 14, 2026 at 12:58:27PM +0300, Marc Finkelbaum wrote:
> Add the required space after the opening '/*' on continuation lines in
> four block comments: the two C2H event format header tables, the
> clear_evt inline comment, and the HW_VAR_DM_FUNC_CLR comment in
> SetHwReg.
>
> No functional change.

...

> /*
> -* C2H event format:
> -* Field TRIGGER CONTENT CMD_SEQ CMD_LEN CMD_ID
> -* BITS [127:120] [119:16] [15:8] [7:4] [3:0]
> -*/
> + * C2H event format:
> + * Field TRIGGER CONTENT CMD_SEQ CMD_LEN CMD_ID
> + * BITS [127:120] [119:16] [15:8] [7:4] [3:0]
> + */

These tables (here and below) are formatted with mixing tab and spaces...

You need to fix that properly to use either tab-based or space-based one,
not the mixed (current) one.

...

> /*
> - * input is already a mask to clear function
> - * don't invert it again! George, Lucas@20130513
> - */
> + * input is already a mask to clear function
> + * don't invert it again! George, Lucas@20130513
> + */

While at it, fix also English grammar and punctuation.

/*
* Input is already a mask to clear function,
* don't invert it again! George, Lucas@20130513
*/

--
With Best Regards,
Andy Shevchenko