From: "Luka Gejak" <luka.gejak@linux.dev>
To: "Luka Gejak" <luka.gejak@linux.dev>,
"Salman Alghamdi" <me@cipherat.com>, <gregkh@linuxfoundation.org>
Cc: <straube.linux@gmail.com>, <linux-staging@lists.linux.dev>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/5] staging: rtl8723bs: rtw_mlme: fix lines exceeding 100 columns
Date: Mon, 27 Apr 2026 08:22:06 +0200 [thread overview]
Message-ID: <DI3PYO2WBVJC.3J79HVNKTFNOO@linux.dev> (raw)
In-Reply-To: <DI3PAOMCIRAL.3FHL3M7JUSBXT@linux.dev>
On Mon Apr 27, 2026 at 7:50 AM CEST, Luka Gejak wrote:
> On Mon Apr 27, 2026 at 12:54 AM CEST, Salman Alghamdi wrote:
>> Wrap long lines and extract local variables to bring all lines
>> within the 100 column limit.
>>
>> Signed-off-by: Salman Alghamdi <me@cipherat.com>
>> ---
...
/* Added by Albert 2009/02/18 */
>> - /* Restore the PMK information to securitypriv structure for the following connection. */
>> - memcpy(&adapter->securitypriv.PMKIDList[0], &backupPMKIDList[0], sizeof(struct rt_pmkid_list) * NUM_PMKID_CACHE);
>> + /* Restore the PMK information to securitypriv structure
>> + * for the following connection.
>> + */
>
> This is not aligned correctly either. f from from should go under R from
> Restore:
> /* Restore the PMK information to securitypriv structure
> * for the following connection.
> */
...
Hi Salman,
this is the only viable change you need to make from this email. I have
verified that the other ones are visual glitches. Other emails are still
valid and you still have to send v4 to address other isues.
Best regards,
Luka Gejak
next prev parent reply other threads:[~2026-04-27 6:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-26 22:54 [PATCH v3 0/5] staging: rtl8723bs: rtw_mlme: fix long lines and related issues Salman Alghamdi
2026-04-26 22:54 ` [PATCH v3 1/5] staging: rtl8723bs: fix buffer over-read in rtw_update_protection Salman Alghamdi
2026-04-26 22:54 ` [PATCH v3 2/5] staging: rtl8723bs: rtw_mlme: fix lines exceeding 100 columns Salman Alghamdi
2026-04-27 5:50 ` Luka Gejak
2026-04-27 6:22 ` Luka Gejak [this message]
2026-04-27 6:02 ` Luka Gejak
2026-04-26 22:55 ` [PATCH v3 3/5] staging: rtl8723bs: rtw_mlme: remove dead commented-out code Salman Alghamdi
2026-04-27 5:32 ` Luka Gejak
2026-04-26 22:55 ` [PATCH v3 4/5] staging: rtl8723bs: rtw_mlme: consolidate capability comparisons lines Salman Alghamdi
2026-04-26 22:55 ` [PATCH v3 5/5] staging: rtl8723bs: rtw_mlme: add blank line for readability Salman Alghamdi
2026-04-26 23:12 ` [PATCH v3 0/5] staging: rtl8723bs: rtw_mlme: fix long lines and related issues Salman Alghamdi
2026-04-27 6:11 ` Luka Gejak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DI3PYO2WBVJC.3J79HVNKTFNOO@linux.dev \
--to=luka.gejak@linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=me@cipherat.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox