From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f51.google.com (mail-oo1-f51.google.com [209.85.161.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF43429B78B for ; Sun, 3 May 2026 15:07:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777820835; cv=none; b=ADnIsDOLTRrFhpx1CkrLAlZLwz2fo6TGXDrgV1hSFGfKNaxYCGjO8mRMOnIAtdWIHqXmj1t00vlmylnfdVzr3mr88xORNFfF+N8oQXQGae3mD+Pbrxl1NdYpeDnMddHkUx0XVgrhldelbbDhQP2ZufeMjXt6zYXCkdWucsZ9pAE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777820835; c=relaxed/simple; bh=J28qUt42U2ywe8Qh758ft7/XmQc3VZ3WZ01C48q0Ejo=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=l0ckBYeb1I45zJ75BBGo/ISPZWQwZcIxlMm1M72WnO0FaeP6vb93nByRIt3S+MGCQgeuDl/qfrnhmcru9IqhZmvhfl01M229YZNPjOCvfl1hdLjn7D/KugvJMYjP95HZLZshEFa5RA/5yi3D8dsizmsdYrph+wwsf4xQY/hlvy0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UfkwEUBl; arc=none smtp.client-ip=209.85.161.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UfkwEUBl" Received: by mail-oo1-f51.google.com with SMTP id 006d021491bc7-69498319ee7so2331776eaf.1 for ; Sun, 03 May 2026 08:07:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777820833; x=1778425633; darn=lists.linux.dev; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gJ32wrJad+vJgf55WvDC0i5Fcg2nT0atoJX8MKvBu0s=; b=UfkwEUBlziQQf8Kxs7Xnji2MyBow3V5HHA14VXypg43hTf5+/NzFiDD7DIg/XYOPVc oqERv0w91vDh51ubxg8Cdxey9zx/TncytDrXEEw+O3cdUPJqnzTzvo5Bhmq3p43nPZDa 7jGOAc4EHcALlwmfhd1TADmTzXDmzBBEV/IrZibkXzSWN+J7+5ZnCWJylC0Ap5VtcidQ rCAzv0QOspYfFo3PzNTaHHdrekgGFd+e5fKvPcN7rUHAMviGVYZV9MJHl06fq6uF6FTf p1cv0UIFEnFRuGlwNrbddkc6Z9mxkodU9+j6SDAW273Ar73i5YszxTsQT127SJc24KxU oLPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777820833; x=1778425633; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=gJ32wrJad+vJgf55WvDC0i5Fcg2nT0atoJX8MKvBu0s=; b=l2BwzNM+rfcPL8sCnGAyJCSUhsNRium3ztscOee3t6D3VbR1VZ2eItCb/WYsE0+ho/ PSHpNDboevCJpGNLZk8S1o7bW+9kc1Mj8vsrwjMAEmUmJbwP/+R5Dr9WWblUI8s3SFxP vM2YoDD39jpctV0mVDnrDRwnetiRR6nAln980gBGBY86n+l18rbm04+MXsQeAgtC0H1M IOKc4SVLrYroLMNiEdhVPipS3VrHVLV19XpG++E9Z8F4K+TEzS0j2bYTEa4rmBhHxa7z ow/SnMD3Shxzb0v+ENVkp7FnvngFoW/lZG+5DIMcXZ69n2SXpe/TpGdMDDgk+UzktcRJ 6bUQ== X-Forwarded-Encrypted: i=1; AFNElJ/GqKF0DFwxfo1pytISrf2GO4UlmxY1vFU2I5P+pO6zRywpvjSt9kn8KSAhV4y7Nf7URdelcMyTLcqLlA9b@lists.linux.dev X-Gm-Message-State: AOJu0YwFOxgAa7DLAX8hoqTKV58v2v0dmPmKFnuUilWwLFoXvPqifvbf byB0a8dPob75UfKXPrlY9XyfwQj57hRRsowH9/2YWxAnEg6/BswMfb8c X-Gm-Gg: AeBDiet0EcU/BuN90H1JtIVvXF19+FhrVe+IkEUy9SXb5d/TptND2i7esqaT41XjpSh C1ITEYbY9EEvWcdv4tgoB2g1rfq8r9yvpBE4Gx8ttI1wUqPJCt8H1R/Y9aPG/GjJrT25biBYaie zDzt7qY2sUc4ESvJv928QHqZFjFLFAqgc+sVFJrZCp64H/0uCmR6roJxVA7YuqvFKk0nlPdLFrW 1JJdOMTDNE4OBtkZKWXq0Lp+nPuLKpzjwN/D17FImcRwg7Qs6pIV5Ll22dLeALHLWm8JqTe5KoR QRUAOdw75LOJPc9B9GqVNE6e/Jr1ZbJmMDyVdMyfxme2VVuimgJJhgmhqCQkuu+x7TmdWp62xdw fNnK2/wR6Uv1JeLprUVoPPLV9seoLudPc8yv/xS8WtoQaJYp1bXq1BzEf6kWJHiHwAQUrte9WHa RAMU8rQSPuyRvRRb6aCEgMV2MoB7vK1+uEqC3IPg/kUNwLwtcemvZIE+RiqeI7 X-Received: by 2002:a05:6820:1352:b0:696:1b32:f14 with SMTP id 006d021491bc7-69696ba2752mr2762840eaf.14.1777820832679; Sun, 03 May 2026 08:07:12 -0700 (PDT) Received: from localhost (23-88-128-2.fttp.usinternet.com. [23.88.128.2]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-69689440f5asm4758594eaf.1.2026.05.03.08.07.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 03 May 2026 08:07:12 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sun, 03 May 2026 10:07:11 -0500 Message-Id: Cc: "Angus Gardner" , , , , , , Subject: Re: [PATCH] staging: iio: ad9834: fix probe error handling and comment typo From: "Maxwell Doose" To: "Joshua Crofts" , "Maxwell Doose" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260502021815.3953423-1-angusg778@gmail.com> In-Reply-To: On Sun May 3, 2026 at 3:53 AM CDT, Joshua Crofts wrote: > On Sat, 2 May 2026 at 21:54, Maxwell Doose wrote: >> >> Hi Angus, >> >> On Fri May 1, 2026 at 9:18 PM CDT, Angus Gardner w= rote: >> > Use dev_err_probe() for the master clock error path instead of open-co= ding >> > dev_err() + PTR_ERR(), consistent with the avdd regulator error path a= bove >> > it and with the equivalent driver ad9832.c. > > I found another dev_err() call in the same function, maybe change this on= e also? > https://elixir.bootlin.com/linux/v7.0.1/source/drivers/staging/iio/freque= ncy/ad9834.c#L452 > Shoot, I seem to have missed that in my review. Nice catch. > >> > Simplify the -ENOMEM return after devm_iio_device_alloc() to a direct >> > return rather than bouncing through a local variable. >> > >> > Fix a copy-paste typo in two comments that referred to 'AD9843' instea= d >> > of the correct chip name 'AD9834'. >> > >> > Signed-off-by: Angus Gardner >> > --- >> > drivers/staging/iio/frequency/ad9834.c | 17 +++++++---------- >> > 1 file changed, 7 insertions(+), 10 deletions(-) >> > >> >> Patch itself looks good but maybe rephrase subject to say "Use probe >> error handling and fix comment typo" instead? "Fix" seems a bit generic >> for my tastes, and we're not really fixing anything anyways. >> >> I'm not the final authority on naming so its at the discretion of >> either Andy or Jonathan, and maybe Greg. So either way, >> Reviewed-by: Maxwell Doose > > You're mixing different logical changes into one patch, therefore it's > harder to review and harder to keep track of the changes after merging > (e.g. running git blame). Instead, you should have a series (named > something like "ad9834: driver cleanup") and three patches under it: > 1. simplify -ENOMEM errno return > 2. use dev_err_probe() > 3. fix typos in comments > Of course this is undeniable but I think the other changes are so miniscule that it wouldn't matter as much, but that's just my personal opinion. Angus, you should probably split this into a patch series. Either way, I still stand by my reviewed-by, at least based on technical correctness, but make sure you at least add the missing dev_err_probe() call that Joshua wanted Angus :) best regards, maxwell