From: Luka Gejak <luka.gejak@linux.dev>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: osdevhari@gmail.com, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: rtl8723bs: fix alignment issue in rtw_xmit.c
Date: Sat, 18 Apr 2026 09:44:20 +0200 [thread overview]
Message-ID: <FDF5583E-F2E0-4932-9243-526758230803@linux.dev> (raw)
In-Reply-To: <2026041857-overpass-deepness-5a29@gregkh>
On April 18, 2026 9:37:32 AM GMT+02:00, Greg KH <gregkh@linuxfoundation.org> wrote:
>On Sat, Apr 18, 2026 at 09:29:40AM +0200, Luka Gejak wrote:
>> On April 18, 2026 9:11:40 AM GMT+02:00, Greg KH <gregkh@linuxfoundation.org> wrote:
>> >On Sat, Apr 18, 2026 at 08:57:08AM +0200, Luka Gejak wrote:
>> >> Hi Osdevhari,
>> >> Let's start from the top of the email. Firstly attachments are not
>> >> allowed, only plaintext. Secondly Signed-off-by tag must use your real
>> >> name(Firstname Lastname <email>. Thirdly, you should setup git
>> >> send-email and use it to send patches. One more thing why did you
>> >> resend same email twice?
>> >> Best regards,
>> >> Luka Gejak
>> >
>> >Luka, please do not review patches like this, it is not the correct way.
>> >Please do so, by not using AI results, and doing so in the in-line
>> >fashion, like the style of what we do.
>> >
>> >And there is no requirement to use git send-email.
>> >
>> >Your email here alone has no context at all, making it impossible to
>> >properly quote or respond to. Please don't do that.
>> >
>> >thanks,
>> >
>> >greg k-h
>>
>> Hi Greg,
>> First of all it is not an ai response, and I didn't see need for
>> quotes because I didn't actually talk about code but if prefer quotes
>> at all times just let me know. And I suggested git send-email because
>> it is easier for sending patches without worrying about plaintext or
>> attachments. Also do you know how to get quotas from mailing list to
>> my phone without manually copy pasting and adding >, since I am not by
>> my laptop right now and I don't know about something like lei for
>> mobile. Also to clarify I used such tone becouse he is a begginer if
>> that is what made you think this is ai review.
>
>Please do not us a phone email client that can not properly handle email
>quoting for reviewing new developer's patch submissions. There is no
>rush here, nor need to confuse them with a style that is not the normal
>way of development we use at all.
>
It can do proper quoting but it takes a lot of time to copy it. If I
was cced I would have no problem using quotes on my phone either. I
use an app called acode in which I write emails(because of formating
and line length) and then send it.
>
>And yes, the "tone" sounds like AI, please don't do that.
>
I understand and I won't do that anymore. I thought since he was a
begginer it would be better use such tone instead of being bold for
example as he would probably take it in differently.
Best regards,
Luka Gejak
>thanks,
>
>greg k-h
next prev parent reply other threads:[~2026-04-18 7:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-18 3:01 [PATCH] staging: rtl8723bs: fix alignment issue in rtw_xmit.c Hari Haran
2026-04-18 6:57 ` Luka Gejak
2026-04-18 7:11 ` Greg KH
2026-04-18 7:29 ` Luka Gejak
2026-04-18 7:37 ` Greg KH
2026-04-18 7:44 ` Luka Gejak [this message]
2026-04-18 8:04 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FDF5583E-F2E0-4932-9243-526758230803@linux.dev \
--to=luka.gejak@linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=osdevhari@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox