From: Dan Carpenter <error27@gmail.com>
To: Rohit Chavan <roheetchavan@gmail.com>
Cc: Martyn Welch <martyn@welchs.me.uk>,
Manohar Vanga <manohar.vanga@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: vme: remove unnecessary parentheses
Date: Fri, 24 Feb 2023 14:09:33 +0300 [thread overview]
Message-ID: <Y/ia7a6YdjpfUAx4@kadam> (raw)
In-Reply-To: <20230224105048.758-1-roheetchavan@gmail.com>
On Fri, Feb 24, 2023 at 04:20:48PM +0530, Rohit Chavan wrote:
> This patch removes unnecessary parentheses in order to fix a checkpatch issue.
>
This line is too long. Commit messages can only have 75 characters
per line. Please run checkpatch.pl on your patches.
But also Greg doesn't like the "unnecessary parentheses" warning so just
ignore checkpatch for those warnings.
regards,
dan carpenter
prev parent reply other threads:[~2023-02-24 11:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 10:50 [PATCH] staging: vme: remove unnecessary parentheses Rohit Chavan
2023-02-24 11:07 ` Greg Kroah-Hartman
2023-02-24 11:09 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/ia7a6YdjpfUAx4@kadam \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=manohar.vanga@gmail.com \
--cc=martyn@welchs.me.uk \
--cc=roheetchavan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox