Linux kernel staging patches
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: Shibo Li <zzutcyha@163.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
	Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8712: Fixes the problem of irregular indentation
Date: Mon, 27 Feb 2023 07:45:11 +0300	[thread overview]
Message-ID: <Y/w1V5cYwTfDVn5p@kadam> (raw)
In-Reply-To: <20230226122820.194074-1-zzutcyha@163.com>

On Sun, Feb 26, 2023 at 12:28:20PM +0000, Shibo Li wrote:
> This patch fixes the problem of irregular indentation
> 
> Signed-off-by: Shibo Li <zzutcyha@163.com>
> ---
>  drivers/staging/rtl8712/rtl871x_mlme.c | 182 ++++++++++++-------------
>  1 file changed, 91 insertions(+), 91 deletions(-)
> 
> diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
> index fccfa0915a02..d8af4f370060 100644
> --- a/drivers/staging/rtl8712/rtl871x_mlme.c
> +++ b/drivers/staging/rtl8712/rtl871x_mlme.c
> @@ -51,7 +51,7 @@ int r8712_init_mlme_priv(struct _adapter *padapter)
>  	set_scanned_network_val(pmlmepriv, 0);
>  	memset(&pmlmepriv->assoc_ssid, 0, sizeof(struct ndis_802_11_ssid));
>  	pbuf = kmalloc_array(MAX_BSS_CNT, sizeof(struct wlan_network),
> -			     GFP_ATOMIC);
> +				GFP_ATOMIC);

The original was correct and the new version is incorrect.  Checkpatch
will complain about the new version if you re-run checkpatch on the file
(not if you run it on the patch itself).

CHECK: Alignment should match open parenthesis
#54: FILE: drivers/staging/rtl8712/rtl871x_mlme.c:54:
+       pbuf = kmalloc_array(MAX_BSS_CNT, sizeof(struct wlan_network),
+                               GFP_ATOMIC);

regards,
dan carpenter


  reply	other threads:[~2023-02-27  4:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-26 12:28 [PATCH] staging: rtl8712: Fixes the problem of irregular indentation Shibo Li
2023-02-27  4:45 ` Dan Carpenter [this message]
2023-03-02  5:05 ` [PATCH v2] staging: rtl8712: Fix some alignment matching open parenthesis issue Shibo Li
2023-03-08 16:02   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y/w1V5cYwTfDVn5p@kadam \
    --to=error27@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=florian.c.schilhabel@googlemail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=zzutcyha@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox