From: Dan Carpenter <error27@gmail.com>
To: Kang Chen <void0red@gmail.com>
Cc: paskripkin@gmail.com, Larry.Finger@lwfinger.net,
phil@philpotter.co.uk, gregkh@linuxfoundation.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: add a null check of kzalloc in go_add_group_info_attr
Date: Mon, 27 Feb 2023 10:23:11 +0300 [thread overview]
Message-ID: <Y/xaXw9LAOizJEBL@kadam> (raw)
In-Reply-To: <CANE+tVpqZusCq4EXi7UV+jY0XBG+9x6UWh_JGCWKs3pZRMFBXA@mail.gmail.com>
On Mon, Feb 27, 2023 at 03:11:21PM +0800, Kang Chen wrote:
> Hi, Dan,
>
> Thanks for your review.
> I noticed there is no error handling in the origin design (this call chain).
> go_add_group_info_attr returns a len-like value indicating the length
> of pbuf.
> I don't think throwing an error to the caller is a good idea, the caller
> doesn't seem to care about it.
> So inserting a netdev_dbg or pr_debug here might be enough.
> Do you have a better idea?
>
The bug is real, yes. But you have your static checker which can detect
it and I also have an unpublished static checker test which detects this
bug.
drivers/staging/r8188eu/core/rtw_p2p.c:106 go_add_group_info_attr() warn: 'pdata_attr' was never checked for NULL
If we just hide the bug enough for so that the static checker cannot
find the bug then we're taking a step backward. When this driver is
ready to leave staging then normally I review every static checker
warning. But if we hide the warning then it will never be fixed.
regards,
dan carpenter
prev parent reply other threads:[~2023-02-27 7:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-26 13:25 [PATCH] staging: r8188eu: add a null check of kzalloc in go_add_group_info_attr Kang Chen
2023-02-27 4:47 ` Dan Carpenter
2023-02-27 7:11 ` Kang Chen
2023-02-27 7:18 ` Dan Carpenter
2023-02-27 7:23 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/xaXw9LAOizJEBL@kadam \
--to=error27@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=paskripkin@gmail.com \
--cc=phil@philpotter.co.uk \
--cc=void0red@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox