From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from msg-1.mailo.com (msg-1.mailo.com [213.182.54.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 143A97F; Mon, 17 Oct 2022 21:05:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1666040748; bh=vtw5hXDB4zueH2hLIVyRWPMtb7MOa/LxMyQnrNM0I90=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=iZMNZjTUW7eR0ru9UAVs94dLpe1f8CAcgh7hzPhOTkTTeTm7aHZXwX0esFVdMIF18 jRnTsmd4zFzSkc28UyjD+3QVD6DE1cmg9ZETbn2SAL8sOgH/V/x02TFYpxgwYwcEgw gj7DHSczjjy3cGu8CBf0B14KzYePn+NYJmbWY7Dk= Received: by b-4.in.mailobj.net [192.168.90.14] with ESMTP via [213.182.55.206] Mon, 17 Oct 2022 23:05:48 +0200 (CEST) X-EA-Auth: slUdyKLY0YFpRa7Q8yUAnoqkQKTYA7BQSzx+lvgyXyaYXMdg/jb8ykPJLy++e4IS1meRsVw1IaITvvPAUrLhOxmy4o5Tp/eQ Date: Tue, 18 Oct 2022 02:35:40 +0530 From: Deepak R Varma To: Julia Lawall Cc: outreachy@lists.linux.dev, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, kumarpraveen@linux.microsoft.com, saurabh.truth@gmail.com Subject: Re: [PATCH] staging: most: dim2: read done_buffers count locally from HDM channel Message-ID: References: Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Oct 17, 2022 at 10:56:03PM +0200, Julia Lawall wrote: > > > On Tue, 18 Oct 2022, Deepak R Varma wrote: > > > The done_buffer count can be directly read from HDM channel instead of > > calling the dim_get_channel_state function. This change also results in > > obsoleting the dim_channel_state local structure variable. > > > > Signed-off-by: Deepak R Varma > > --- > > > > PLEASE NOTE: I have only built the module on my machine, but have not tested it. > > I am not sure how to test this change. I am willing to test it with appropriate > > guidance provided I have the necessary hardware. > > For non experts, maybe it would be helpful to explain what motivated you > to do this? I was actually trying to understand the implementation of this module to determine if I can replace BUG_ON calls by WARN_ON_ONCE. A "ctrl+]" navigation took me to this function and I started wondering about why the function call would be necessary. Hence the change. While reading the Documentation under dim2 directory, I realised this module may need a specialised hardware for testing [automotive???]. Hence I was not sure how to test the same. Are you suggesting I mention this in the patch description (the motivation)? Thank you, ./drv > > julia > > > > > drivers/staging/most/dim2/dim2.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c > > index ab72e11ac5ab..4c1f27898a29 100644 > > --- a/drivers/staging/most/dim2/dim2.c > > +++ b/drivers/staging/most/dim2/dim2.c > > @@ -259,7 +259,6 @@ static void retrieve_netinfo(struct dim2_hdm *dev, struct mbo *mbo) > > static void service_done_flag(struct dim2_hdm *dev, int ch_idx) > > { > > struct hdm_channel *hdm_ch = dev->hch + ch_idx; > > - struct dim_ch_state_t st; > > struct list_head *head; > > struct mbo *mbo; > > int done_buffers; > > @@ -271,7 +270,7 @@ static void service_done_flag(struct dim2_hdm *dev, int ch_idx) > > > > spin_lock_irqsave(&dim_lock, flags); > > > > - done_buffers = dim_get_channel_state(&hdm_ch->ch, &st)->done_buffers; > > + done_buffers = hdm_ch->ch.done_sw_buffers_number; > > if (!done_buffers) { > > spin_unlock_irqrestore(&dim_lock, flags); > > return; > > -- > > 2.30.2 > > > > > > > > > >