From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3F174C72; Tue, 18 Oct 2022 18:07:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0CA30C433C1; Tue, 18 Oct 2022 18:07:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666116440; bh=w+fQbjU9zgPkXn50Lx/9I+Hk07Z6bEGihhobfKnfWB0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=j/2fBJtOMdCWu/3mQEm8TEytOtXNJgJ+ct1/Ega3z/+TCXyVwQXPQfBl5NVVdwE7T YdZXBKQFhvqUoR5zeng0489LrvSMzkObHun6CSsbKH6xFQJJWv6xG0Vc3aRyUa1QTX AYY+OgwPMEgqA2urmSSaIaPjXLQILXOOSsX9d/bc= Date: Tue, 18 Oct 2022 20:07:17 +0200 From: Greg KH To: Deepak R Varma Cc: outreachy@lists.linux.dev, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] staging: most: dim2: read done_buffers count locally from HDM channel Message-ID: References: <83fd237d2ac157d234e9c7cce1206904c2d8773d.1666105876.git.drv@mailo.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Oct 18, 2022 at 11:10:34PM +0530, Deepak R Varma wrote: > On Tue, Oct 18, 2022 at 07:12:45PM +0200, Greg KH wrote: > > On Tue, Oct 18, 2022 at 10:19:21PM +0530, Deepak R Varma wrote: > > > The function dim_get_channel_state only serves to initialize the ready and > > > done_buffers fields of the structure passed as its second argument. In > > > service_done_flag, this structure is never used again and the only purpose > > > of the call is to get the value that is put in the done_buffers field. > > > But that value is just the done_sw_buffers_number field of the call's > > > first argument. So the whole call is useless, and we can just replace it > > > with an access to this field. > > > > > > This change implies that the variable st is no longer used, so drop it as > > > well. > > > > > > Signed-off-by: Deepak R Varma > > > --- > > > > > > PLEASE NOTE: > > > 1. I have only built the module on my machine, but have not tested it. > > > I am not sure how to test this change. I am willing to test it with > > > appropriate guidance provided I have the necessary hardware. > > > 2. This was a standalone patch earlier. It is now combined into a patch set > > > with another patch for the same driver. Hence I am carry forwarding the > > > change log for this patch here: > > > > > > Changes in v3: > > > 1. The patch log message is further improved. This revised verbiage is as > > > thankfully provided by julia.lawall@inria.fr > > > > > > Changes in v2: > > > 1. Update patch log message to be more descriptive about the reason for change. > > > Feedback provided by julia.lawall@inria.fr > > > > > > > You need to say this is a v3 in the subject line as documented :( > > > Hi Greg, > This was a standalone patch earlier and first time included in the patch set. I > was not aware I am allowed to version a patch individually, different from the > cover letter. I have posted a query to Outreachy mailing list for additional > clarification. I will send in a v4 once I have clarity. The cover letter will have v4 and so will each individual patch. Turning 1 patch into a series or adding new patches to a series does not mean you start over with the numbering. Otherwise that would be impossible for us to track, right? thanks, greg k-h