[PATCH 1/2] staging: most: dim2: read done_buffers count locally from HDM channel

Deepak R Varma
2022-10-18T16:49:32Z

The function dim_get_channel_state only serves to initialize the ready and
done_buffers fields of the structure passed as its second argument. In
service_done_flag, this structure is never used again and the only purpose
of the call is to get the value that is put in the done_buffers field.
But that value is just the done_sw_buffers_number field of the call's
first argument. So the whole call is useless, and we can just replace it
with an access to this field.

This change implies that the variable st is no longer used, so drop it as
well.

Signed-off-by: Deepak R Varma <drv@mailo.com>
---

PLEASE NOTE:
1. I have only built the module on my machine, but have not tested it.
I am not sure how to test this change. I am willing to test it with
appropriate guidance provided I have the necessary hardware.
2. This was a standalone patch earlier. It is now combined into a patch set
with another patch for the same driver. Hence I am carry forwarding the
change log for this patch here:

Changes in v3:
1. The patch log message is further improved. This revised verbiage is as
thankfully provided by julia.lawall@inria.fr

Changes in v2:
1. Update patch log message to be more descriptive about the reason for change.
Feedback provided by julia.lawall@inria.fr

drivers/staging/most/dim2/dim2.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c
index ab72e11ac5ab..4c1f27898a29 100644
--- a/drivers/staging/most/dim2/dim2.c
+++ b/drivers/staging/most/dim2/dim2.c
@@ -259,7 +259,6 @@ static void retrieve_netinfo(struct dim2_hdm *dev, struct mbo *mbo)
static void service_done_flag(struct dim2_hdm *dev, int ch_idx)
{
struct hdm_channel *hdm_ch = dev->hch + ch_idx;
- struct dim_ch_state_t st;
struct list_head *head;
struct mbo *mbo;
int done_buffers;
@@ -271,7 +270,7 @@ static void service_done_flag(struct dim2_hdm *dev, int ch_idx)

spin_lock_irqsave(&dim_lock, flags);

- done_buffers = dim_get_channel_state(&hdm_ch->ch, &st)->done_buffers;
+ done_buffers = hdm_ch->ch.done_sw_buffers_number;
if (!done_buffers) {
spin_unlock_irqrestore(&dim_lock, flags);
return;
--
2.30.2