From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BE7020E3
	for <linux-staging@lists.linux.dev>; Thu, 13 Oct 2022 05:54:23 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16830C433C1;
	Thu, 13 Oct 2022 05:54:22 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1665640463;
	bh=QAO54DZz+VWkoUxgrAlLsddpVvHW6nR+uyTGLgPGfVU=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=rIkwlk8GryVzVbXCXV6iTEHHiC15ub0C/4rE2OlJF9ePJxeC87yiGfFFHuwvfFvXh
	 cC35A8AcdBy5hijsR5PiThqYeFQBxOTpIbMWk45JScchrRHKsSCRI5Bb5sa6mpUZ0G
	 +c7baipORdPufhXMc+dFJ/PY3LS0BJ4Z31TJw+zs=
Date: Thu, 13 Oct 2022 07:55:07 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sasha Levin <sashal@kernel.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	GUO Zihua <guozihua@huawei.com>, philipp.g.hortmann@gmail.com,
	dan.carpenter@oracle.com, dave@stgolabs.net,
	yangyingliang@huawei.com, yogi.kernel@gmail.com,
	f3sch.git@outlook.com, linux-staging@lists.linux.dev
Subject: Re: [PATCH AUTOSEL 5.4 07/27] staging: rtl8192e: Fix return type for
 implementation of ndo_start_xmit
Message-ID: <Y0eoOwU1cT7N9ywF@kroah.com>
References: <20221013002501.1895204-1-sashal@kernel.org>
 <20221013002501.1895204-7-sashal@kernel.org>
Precedence: bulk
X-Mailing-List: linux-staging@lists.linux.dev
List-Id: <linux-staging.lists.linux.dev>
List-Subscribe: <mailto:linux-staging+subscribe@lists.linux.dev>
List-Unsubscribe: <mailto:linux-staging+unsubscribe@lists.linux.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221013002501.1895204-7-sashal@kernel.org>

On Wed, Oct 12, 2022 at 08:24:39PM -0400, Sasha Levin wrote:
> From: GUO Zihua <guozihua@huawei.com>
> 
> [ Upstream commit 513d9a61156d79dd0979c4ad400c8587f52cbb9d ]
> 
> CFI (Control Flow Integrity) is a safety feature allowing the system to
> detect and react should a potential control flow hijacking occurs. In
> particular, the Forward-Edge CFI protects indirect function calls by
> ensuring the prototype of function that is actually called matches the
> definition of the function hook.
> 
> Since Linux now supports CFI, it will be a good idea to fix mismatched
> return type for implementation of hooks. Otherwise this would get
> cought out by CFI and cause a panic.

Not needed in any stable branch, please drop from all.

thanks,

greg k-h