From: Sasha Levin <sashal@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
GUO Zihua <guozihua@huawei.com>,
Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com,
fmdefrancesco@gmail.com, skumark1902@gmail.com,
asif.kgauri@gmail.com, linux-staging@lists.linux.dev
Subject: Re: [PATCH AUTOSEL 5.4 06/27] staging: rtl8712: Fix return type for implementation of ndo_start_xmit
Date: Thu, 13 Oct 2022 13:51:40 -0400 [thread overview]
Message-ID: <Y0hQLEXtrz542h2m@sashalap> (raw)
In-Reply-To: <Y0eoWDmylWzZjcNA@kroah.com>
On Thu, Oct 13, 2022 at 07:55:36AM +0200, Greg Kroah-Hartman wrote:
>On Wed, Oct 12, 2022 at 08:24:38PM -0400, Sasha Levin wrote:
>> From: GUO Zihua <guozihua@huawei.com>
>>
>> [ Upstream commit 307d343620e1fc7a6a2b7a1cdadb705532c9b6a5 ]
>>
>> CFI (Control Flow Integrity) is a safety feature allowing the system to
>> detect and react should a potential control flow hijacking occurs. In
>> particular, the Forward-Edge CFI protects indirect function calls by
>> ensuring the prototype of function that is actually called matches the
>> definition of the function hook.
>>
>> Since Linux now supports CFI, it will be a good idea to fix mismatched
>> return type for implementation of hooks. Otherwise this would get
>> cought out by CFI and cause a panic.
>
>And another that should be dropped from all stable branches, thanks.
Ack, I'll drop this and the rest of the staging patches you've pointed
out.
--
Thanks,
Sasha
next prev parent reply other threads:[~2022-10-13 17:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221013002501.1895204-1-sashal@kernel.org>
2022-10-13 0:24 ` [PATCH AUTOSEL 5.4 06/27] staging: rtl8712: Fix return type for implementation of ndo_start_xmit Sasha Levin
2022-10-13 5:55 ` Greg Kroah-Hartman
2022-10-13 17:51 ` Sasha Levin [this message]
2022-10-13 0:24 ` [PATCH AUTOSEL 5.4 07/27] staging: rtl8192e: " Sasha Levin
2022-10-13 5:55 ` Greg Kroah-Hartman
2022-10-13 0:24 ` [PATCH AUTOSEL 5.4 09/27] staging: vt6655: fix potential memory leak Sasha Levin
2022-10-13 0:24 ` [PATCH AUTOSEL 5.4 19/27] staging: rtl8723bs: fix a potential memory leak in rtw_init_cmd_priv() Sasha Levin
2022-10-13 0:24 ` [PATCH AUTOSEL 5.4 20/27] staging: rtl8192u: Fix return type of ieee80211_xmit Sasha Levin
2022-10-13 0:24 ` [PATCH AUTOSEL 5.4 21/27] staging: octeon: Fix return type of cvm_oct_xmit and cvm_oct_xmit_pow Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0hQLEXtrz542h2m@sashalap \
--to=sashal@kernel.org \
--cc=Larry.Finger@lwfinger.net \
--cc=asif.kgauri@gmail.com \
--cc=florian.c.schilhabel@googlemail.com \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=guozihua@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=skumark1902@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox