From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 139331C01 for ; Sun, 16 Oct 2022 14:56:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D71BC433D6; Sun, 16 Oct 2022 14:56:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1665932213; bh=57qM6HUpaEnGUo3CmkaIDIQQ+FdtDErLhqmXmdgGouY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GTCEbDvQN5b0Cxrjai8wcPGCbVFxD6K8xrzw9IHgoMYZZ5busluWSPPwCDiAe2LbA UI/KkIiohnw2WQH9gUTFfQPN1LI2NFM5jG4OeShcwbcdvcbJRHOnur5JObVa8OnwwA YrQmPSygUoeAaJ/phz9tEBcdtFqGCUdcx+Lhoxdc= Date: Sun, 16 Oct 2022 16:57:40 +0200 From: Greg Kroah-Hartman To: Sasha Levin Cc: Joe Perches , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Michael Straube , Philipp Hortmann , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, martin@kaiser.cx, paskripkin@gmail.com, gszymaszek@short.pl, fmdefrancesco@gmail.com, makvihas@gmail.com, saurav.girepunje@gmail.com, linux-staging@lists.linux.dev Subject: Re: [PATCH AUTOSEL 5.19 01/63] staging: r8188eu: do not spam the kernel log Message-ID: References: <20221013001842.1893243-1-sashal@kernel.org> <60af3294445ba2d2289a32ef7e429111ff476b44.camel@perches.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sun, Oct 16, 2022 at 09:32:07AM -0400, Sasha Levin wrote: > On Thu, Oct 13, 2022 at 06:46:12AM +0200, Greg Kroah-Hartman wrote: > > On Wed, Oct 12, 2022 at 08:08:58PM -0700, Joe Perches wrote: > > > On Wed, 2022-10-12 at 20:17 -0400, Sasha Levin wrote: > > > > From: Michael Straube > > > > > > > > [ Upstream commit 9a4d0d1c21b974454926c3b832b4728679d818eb ] > > > > > > > > Drivers should not spam the kernel log if they work properly. Convert > > > > the functions Hal_EfuseParseIDCode88E() and _netdev_open() to use > > > > netdev_dbg() instead of pr_info() so that developers can still enable > > > > it if they want to see this information. > > > > > > Why should this be backported? > > > > I agree, Sasha please drop this from all branches. > > I'll drop it, but for the record: I've been picking up patches that help > with log spam like any other regular fixes. Being on the receiving end > of spammy kernel code and making debugging issues much harder, I think > it's as important (if not more) than some other classes of fixes we pick > up. Ah, ok, fair enough. You can leave this one in your queue if you still have it around. thanks, greg k-h