public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Tanju Brunostar <tanjubrunostar0@gmail.com>,
	Bhaskar Chowdhury <unixbhaskar@gmail.com>,
	linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
	outreachy@lists.linux.dev
Subject: Re: Request for assistance
Date: Thu, 20 Oct 2022 10:39:47 -0400	[thread overview]
Message-ID: <Y1Fds7BJjY/OcwU0@mit.edu> (raw)
In-Reply-To: <Y1E6qYkzkRxlloNp@kroah.com>

Tanju, some additional hints.  First of all, please don't send cleanup
patches to address checkpatch --file complaints about overly long
lines.  It's generally not worth the code churn.

Secondly for code that *you* are writing, think about why you have
lines which are exceeding the line width in the first place.  Is it
because code is being nested too deeply, and perhaps some judicious
function refactoring with good function names might make the code
clearer?  Would adding some temporary variables that are judiciously
named make the code look clearer?

The rules about "thou shalt never have lines which exceed 78
characters" are rules of thumb.  The high level goal is to make the
code more readable and easier to understand, since good code is
maintainable code.  And sometimes it's not just about where to split
lines of code but whether there is a better way to structure the code
so that long lines aren't needed in the first place.

Cheers,

					- Ted

  reply	other threads:[~2022-10-20 14:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-20 11:00 Request for assistance Ubuntu
2022-10-20 11:10 ` Greg KH
2022-10-20 11:14   ` Tanju Brunostar
2022-10-20 11:59     ` Julia Lawall
     [not found] ` <CAOkYk0iU0B98JsH77avky--AS19V=GhQox2f_b4PAG3ZBB+SVQ@mail.gmail.com>
2022-10-20 11:34   ` Tanju Brunostar
2022-10-20 12:10     ` Greg KH
2022-10-20 14:39       ` Theodore Ts'o [this message]
     [not found]         ` <Y1Hby38PE/QVlRhF@Slackware>
2022-10-21  6:11           ` Tanju Brunostar
  -- strict thread matches above, loose matches on Subject: below --
2022-10-22  8:11 request " Tanju Brunostar
2022-10-22  8:13 ` Julia Lawall
2022-10-22  8:20   ` Tanju Brunostar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y1Fds7BJjY/OcwU0@mit.edu \
    --to=tytso@mit.edu \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=outreachy@lists.linux.dev \
    --cc=tanjubrunostar0@gmail.com \
    --cc=unixbhaskar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox