From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kang Minchul <tegongkang@gmail.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Pavel Skripkin <paskripkin@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] staging: r8188eu: remove unnecessary variable in rtw_recv
Date: Mon, 24 Oct 2022 09:35:23 +0300 [thread overview]
Message-ID: <Y1YyK7YYshq1nayg@kadam> (raw)
In-Reply-To: <20221023200532.259276-3-tegongkang@gmail.com>
On Mon, Oct 24, 2022 at 05:05:30AM +0900, Kang Minchul wrote:
> Return _SUCCESS directly instead of storing it in a variable.
> This can prevent cocci warning as follows:
>
> Unneeded variable: "ret". Return "_SUCCESS" on line 1516
>
> Signed-off-by: Kang Minchul <tegongkang@gmail.com>
Make the function void instead.
regards,
dan carpenter
next prev parent reply other threads:[~2022-10-24 6:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-23 20:05 [PATCH 0/4] staging: r8188eu: cleaning up unused variable Kang Minchul
2022-10-23 20:05 ` [PATCH 1/4] staging: r8188eu: remove unnecessary variable in ioctl_linux Kang Minchul
2022-10-23 20:05 ` [PATCH 2/4] staging: r8188eu: remove unnecessary variable in rtw_recv Kang Minchul
2022-10-24 6:35 ` Dan Carpenter [this message]
2022-10-23 20:05 ` [PATCH 3/4] staging: r8188eu: remove unnecessary variable in rtl8188eu_xmit Kang Minchul
2022-10-23 20:05 ` [PATCH 4/4] staging: r8188eu: remove unnecessary variable in rtw_ap Kang Minchul
2022-10-24 5:33 ` [PATCH 0/4] staging: r8188eu: cleaning up unused variable Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1YyK7YYshq1nayg@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=paskripkin@gmail.com \
--cc=phil@philpotter.co.uk \
--cc=tegongkang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).